This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(ring_theory/kaehler): cleanup instances#19234
Closed
eric-wieser wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore(ring_theory/kaehler): cleanup instances#19234eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser wants to merge 2 commits intomasterfrom
Conversation
The previous module instance has the wrong defeqs, and was more work to construct. The new one remains propositionally equal to the old one.
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 13, 2023
1 task
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 13, 2023
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 14, 2023
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 14, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 16, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 16, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Member
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
The previous module instance has the wrong defeqs, and was more work to construct. The new one remains propositionally equal to the old one.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 24, 2023
Unfortunately I was not able to forward port the addition of a partially-explicit type to `kaehler_differential.End_equiv_derivation'`, as Lean 4 no longer allows metavariables in instance arguments.
fgdorais
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 25, 2023
Unfortunately I was not able to forward port the addition of a partially-explicit type to `kaehler_differential.End_equiv_derivation'`, as Lean 4 no longer allows metavariables in instance arguments.
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 14, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kim-em
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 14, 2023
Unfortunately I was not able to forward port the addition of a partially-explicit type to `kaehler_differential.End_equiv_derivation'`, as Lean 4 no longer allows metavariables in instance arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous module instance has the wrong defeqs, and was more work to construct.
The new one remains propositionally equal to the old one.