[Merged by Bors] - chore: forward-port leanprover-community/mathlib#19234#5879
Closed
eric-wieser wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - chore: forward-port leanprover-community/mathlib#19234#5879eric-wieser wants to merge 6 commits intomasterfrom
eric-wieser wants to merge 6 commits intomasterfrom
Conversation
ce133e6 to
abda5b4
Compare
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 2560af8. |
|
This PR/issue depends on: |
Member
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Unfortunately I was not able to forward port the addition of a partially-explicit type to `kaehler_differential.End_equiv_derivation'`, as Lean 4 no longer allows metavariables in instance arguments.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
fgdorais
pushed a commit
that referenced
this pull request
Jul 25, 2023
Unfortunately I was not able to forward port the addition of a partially-explicit type to `kaehler_differential.End_equiv_derivation'`, as Lean 4 no longer allows metavariables in instance arguments.
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
Unfortunately I was not able to forward port the addition of a partially-explicit type to `kaehler_differential.End_equiv_derivation'`, as Lean 4 no longer allows metavariables in instance arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately I was not able to forward port the addition of a partially-explicit type to
kaehler_differential.End_equiv_derivation', as Lean 4 no longer allows metavariables in instance arguments.As this is a slow file, I thought I should check the refactor is safe in mathlib4 first.