Skip to content

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#19234#5887

Closed
eric-wieser wants to merge 4 commits intomasterfrom
forward-port-19235
Closed

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#19234#5887
eric-wieser wants to merge 4 commits intomasterfrom
forward-port-19235

Conversation

@eric-wieser
Copy link
Copy Markdown
Member


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 14, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 14, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jul 16, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 16, 2023
bors bot pushed a commit that referenced this pull request Jul 16, 2023
@bors
Copy link
Copy Markdown

bors bot commented Jul 16, 2023

Build failed:

@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed ready-to-merge This PR has been sent to bors. labels Jul 16, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jul 16, 2023

Can't see anything but a transient SSL error during the bors build here, so I'm merging master to get a fresh CI.

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 16, 2023
@eric-wieser eric-wieser added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jul 16, 2023
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

(CI is green, I assume that's the only reason this was awaiting author)

@bors
Copy link
Copy Markdown

bors bot commented Jul 16, 2023

Already running a review

@eric-wieser eric-wieser reopened this Jul 16, 2023
@eric-wieser
Copy link
Copy Markdown
Member Author

Whoops, misclick

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 16, 2023
bors bot pushed a commit that referenced this pull request Jul 16, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Jul 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#19234 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#19234 Jul 16, 2023
@bors bors bot closed this Jul 16, 2023
@bors bors bot deleted the forward-port-19235 branch July 16, 2023 14:44
kim-em added a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants