This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(algebra/algebra/operations): the semiring of submodules over an algebra is idempotent#18400
Closed
eric-wieser wants to merge 8 commits intomasterfrom
Closed
[Merged by Bors] - feat(algebra/algebra/operations): the semiring of submodules over an algebra is idempotent#18400eric-wieser wants to merge 8 commits intomasterfrom
eric-wieser wants to merge 8 commits intomasterfrom
Conversation
…algebra is idempotent
YaelDillies
reviewed
Feb 8, 2023
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 9, 2023
1 task
YaelDillies
approved these changes
Feb 16, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
Member
Author
|
maintainer merge (seems not to work in review comments) |
|
🚀 Pull request has been placed on the maintainer queue by eric-wieser. |
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
…algebra is idempotent (#18400) The same results are repeated for `ideal`. The two modifications of ported files are docstrings only, and are forward-ported at leanprover-community/mathlib4#2175. Since this adjusts the import hierarchy slightly, there are some files which now need to qualify names that were previously unambiguous. One proof timed out, but the timeout went away after converting a messy term into tactic mode.
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
cf. #18400 (review) as reviews can only be posted on pr's we don't need these checks, and they were stopping the actions from firing.
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 17, 2023
mo271
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same results are repeated for
ideal.The two modifications of ported files are docstrings only, and are forward-ported at leanprover-community/mathlib4#2175.
Since this adjusts the import hierarchy slightly, there are some files which now need to qualify names that were previously unambiguous.
One proof timed out, but the timeout went away after converting a messy term into tactic mode.