This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - fix(.github/workflows): try a fix for review bodies#18455
Closed
[Merged by Bors] - fix(.github/workflows): try a fix for review bodies#18455
Conversation
|
🚀 Pull request has been placed on the maintainer queue by alexjbest. |
alexjbest
commented
Feb 16, 2023
| ping_zulip: | ||
| name: Ping maintainers on Zulip | ||
| if: (github.event.issue.pull_request != 'null') && (startsWith(github.event.review.body, 'maintainer merge') || contains(toJSON(github.event.review.body), '\r\nmaintainer merge')) | ||
| if: (startsWith(github.event.review.body, 'maintainer merge') || contains(toJSON(github.event.review.body), '\r\nmaintainer merge')) |
|
🚀 Pull request has been placed on the maintainer queue by alexjbest. |
Member
|
bors d+ Feel free to merge if you're done with this. Thanks! |
|
✌️ alexjbest can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
cf. #18400 (review) as reviews can only be posted on pr's we don't need these checks, and they were stopping the actions from firing.
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. #18400 (review)
as reviews can only be posted on pr's we don't need these checks, and they were stopping the actions from firing.