Skip to content

[Merged by Bors] - feat: forward-port leanprover-community/mathlib#18400#2175

Closed
eric-wieser wants to merge 3 commits intomasterfrom
forward-port/18400
Closed

[Merged by Bors] - feat: forward-port leanprover-community/mathlib#18400#2175
eric-wieser wants to merge 3 commits intomasterfrom
forward-port/18400

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser added WIP Work in progress mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Feb 9, 2023
@eric-wieser eric-wieser added needs-mathlib-SHA easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 9, 2023
@fpvandoorn
Copy link
Copy Markdown
Member

bors d+

Please merge after changing the SHAs

@bors
Copy link
Copy Markdown

bors bot commented Feb 16, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 16, 2023
bors bot pushed a commit to leanprover-community/mathlib3 that referenced this pull request Feb 16, 2023
…algebra is idempotent (#18400)

The same results are repeated for `ideal`.

The two modifications of ported files are docstrings only, and are forward-ported at leanprover-community/mathlib4#2175.

Since this adjusts the import hierarchy slightly, there are some files which now need to qualify names that were previously unambiguous.

One proof timed out, but the timeout went away after converting a messy term into tactic mode.
@eric-wieser eric-wieser removed needs-mathlib-SHA WIP Work in progress labels Feb 17, 2023
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 17, 2023
bors bot pushed a commit that referenced this pull request Feb 17, 2023
@bors
Copy link
Copy Markdown

bors bot commented Feb 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: forward-port leanprover-community/mathlib#18400 [Merged by Bors] - feat: forward-port leanprover-community/mathlib#18400 Feb 17, 2023
@bors bors bot closed this Feb 17, 2023
@bors bors bot deleted the forward-port/18400 branch February 17, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants