chore: lake: backport dynlib fixes#8187
Merged
tydeu merged 6 commits intoleanprover:releases/v4.19.0from May 1, 2025
Merged
Conversation
This PR fixes the order of libraries when loading them via `--load-dynlib` or `--plugin` in `lean` and when linking them into a shared library or executable. A `Dynlib` now tracks its dependencies and they are topologically sorted before being passed to either linking or loading. Closes leanprover#7790.
…nprover#8152) This PR fixes a regression where non-precompiled module builds would `--load-dynlib` package `extern_lib` targets. A reappearance of leanprover#4565. Thanks to Daniil [on Zulip](https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Multiple.20extern_lib/near/514772675) for the report! This was not caught by the old test due to the removal of `extern_lib` from the FFI example.
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 30, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 30, 2025
|
Mathlib CI status (docs):
|
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 1, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 1, 2025
…er#8190) This PR adds documentation for native library options (e.g., `dynlibs`, `plugins`, `moreLinkObjs`, `moreLinkLibs`) and `needs` to the Lake README. It is also includes information about specifying targets on the Lake CLI and in Lean and TOML configuration files.
c891a17 to
f424d70
Compare
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 1, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports fixes to dynamic library linking and loading in Lake to
v4.19.0.Includes changes from #7809, #8026, #8152, and #8190.