fix: lake: library load & link order#7809
Merged
tydeu merged 7 commits intoleanprover:masterfrom Apr 6, 2025
Merged
Conversation
2cbd318 to
485e814
Compare
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 4, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 4, 2025
|
Mathlib CI status (docs):
|
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 1550805. Benchmark Metric Change
============================================================
- bv_decide_inequality.lean maxrss 2.0% (20.5 σ)
+ lake build no-op instructions -10.3% (-240.6 σ)
+ lake config import task-clock -3.7% (-11.2 σ)
+ lake config import wall-clock -3.7% (-10.5 σ)
- unionfind task-clock 5.5% (10.3 σ)
- unionfind wall-clock 5.5% (10.3 σ) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 19, 2025
This PR fixes bugs in #7809 and #7909 that were not caught partially because the `badImport` test had been disabled. **Bugs Fixed:** * Building by path no longer drops top-level logs. * "bad import" errors are once again printed. * Transitively imported precompiled modules are once again loaded during elaboration.
tydeu
added a commit
to tydeu/lean4
that referenced
this pull request
Apr 30, 2025
This PR fixes the order of libraries when loading them via `--load-dynlib` or `--plugin` in `lean` and when linking them into a shared library or executable. A `Dynlib` now tracks its dependencies and they are topologically sorted before being passed to either linking or loading. Closes leanprover#7790.
tydeu
added a commit
that referenced
this pull request
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the order of libraries when loading them via
--load-dynlibor--plugininleanand when linking them into a shared library or executable. ADynlibnow tracks its dependencies and they are topologically sorted before being passed to either linking or loading.Closes #7790.