fix: lake: extern_lib loading in non-precompiled module builds#8152
Merged
tydeu merged 1 commit intoleanprover:masterfrom Apr 30, 2025
Merged
fix: lake: extern_lib loading in non-precompiled module builds#8152tydeu merged 1 commit intoleanprover:masterfrom
extern_lib loading in non-precompiled module builds#8152tydeu merged 1 commit intoleanprover:masterfrom
Conversation
extern_lib loading in non-precompiled module builds
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 28, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 28, 2025
|
Mathlib CI status (docs):
|
tydeu
added a commit
to tydeu/lean4
that referenced
this pull request
Apr 30, 2025
…nprover#8152) This PR fixes a regression where non-precompiled module builds would `--load-dynlib` package `extern_lib` targets. A reappearance of leanprover#4565. Thanks to Daniil [on Zulip](https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Multiple.20extern_lib/near/514772675) for the report! This was not caught by the old test due to the removal of `extern_lib` from the FFI example.
tydeu
added a commit
that referenced
this pull request
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression where non-precompiled module builds would
--load-dynlibpackageextern_libtargets.A reappearance of #4565. Thanks to Daniil on Zulip for the report! This was not caught by the old test due to the removal of
extern_libfrom the FFI example.