Skip to content

feat: Int.bmod lemmas#7933

Merged
TwoFX merged 5 commits intomasterfrom
markus/int-bmod-1
Apr 15, 2025
Merged

feat: Int.bmod lemmas#7933
TwoFX merged 5 commits intomasterfrom
markus/int-bmod-1

Conversation

@TwoFX
Copy link
Copy Markdown
Member

@TwoFX TwoFX commented Apr 12, 2025

This PR adds lemmas about Int.bmod to achieve parity between Int.bmod and Int.emod/Int.fmod/Int.tmod. Furthermore, it adds missing lemmas for emod/fmod/tmod and performs cleanup on names and statements for all four operations, also with a view towards increasing consistency with the corresponding Nat.mod lemmas.

@TwoFX TwoFX added the changelog-library Library label Apr 12, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 12, 2025 12:38 Inactive
@TwoFX TwoFX force-pushed the markus/int-bmod-1 branch from 67d2a09 to d840b7d Compare April 12, 2025 12:38
@TwoFX TwoFX changed the base branch from master to nightly-with-mathlib April 14, 2025 07:11
@TwoFX TwoFX changed the base branch from nightly-with-mathlib to master April 15, 2025 09:37
@TwoFX TwoFX force-pushed the markus/int-bmod-1 branch from d840b7d to 5c5eb5b Compare April 15, 2025 09:38
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 15, 2025 09:53 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 15, 2025
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Apr 15, 2025
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 15, 2025
@ghost ghost added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Apr 15, 2025
@ghost
Copy link
Copy Markdown

ghost commented Apr 15, 2025

Mathlib CI status (docs):

@ghost ghost added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Apr 15, 2025
@TwoFX TwoFX marked this pull request as ready for review April 15, 2025 12:26
@TwoFX TwoFX requested a review from kim-em as a code owner April 15, 2025 12:26
@TwoFX TwoFX enabled auto-merge April 15, 2025 12:26
@TwoFX TwoFX added this pull request to the merge queue Apr 15, 2025
Merged via the queue into master with commit c82159e Apr 15, 2025
28 checks passed
kmill added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 19, 2025
* fixes

* fix test

* fix

* chore: adaptations for leanprover/lean4#7797

* stricter rfl check

* fix merge

* Trigger CI for leanprover/lean4#7797

* Trigger CI for leanprover/lean4#7797

* Trigger CI for leanprover/lean4#7797

* inverse construction

* Update lean-toolchain for testing leanprover/lean4#7791

* lake update

* Fix

* Fix

* Fix

* chore: bump to nightly-2025-04-03

* more fixes

* merge lean-pr-testing-6325

* bump proofwidgets

* Update lean-toolchain for testing leanprover/lean4#7812

* shake

* fix shake

* fix tests

* import mathlib.init

* Update lean-toolchain for testing leanprover/lean4#7816

* Trigger CI for leanprover/lean4#7816

* Update lean-toolchain for testing leanprover/lean4#7802

* Fix

* fixes

* Fix (pending upstream changes)

* Trigger CI for leanprover/lean4#7802

* fix

* chore: bump to nightly-2025-04-04

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Update lean-toolchain for testing leanprover/lean4#7818

* Fix

* Fix

* Fix

* Merge master into nightly-testing

* Fix

* Fix comments

* fixes

* Trigger CI for leanprover/lean4#7816

* fix

* fix

* missing doc-string?

* chore: bump to nightly-2025-04-05

* chore: bump to nightly-2025-04-06

* move Batteries to nightly-testing

* lake update

* lint

* fix

* chore: bump to nightly-2025-04-07

* sprinkle noncomputable

* fix: relativize file paths

fix for leanprover/lean4#7822

* chore: reset cache

* chore: bump to nightly-2025-04-07

* shake

* fix: relativize more

* Update lean-toolchain for testing leanprover/lean4#7856

* Update lean-toolchain for testing leanprover/lean4#7851

* Fix

* Fix

* Fix

* Fix

* chore: bump to nightly-2025-04-08

* Update lean-toolchain for testing leanprover/lean4#7870

* Trigger CI for leanprover/lean4#7870

* Trigger CI for leanprover/lean4#7870

* Trigger CI for leanprover/lean4#7870

* wip

* Trigger CI for leanprover/lean4#7870

* .

* chore: bump to nightly-2025-04-09

* Trigger CI for leanprover/lean4#7870

* .

* bump

* lake update

* fixes for leanprover/lean4#7873

* fixes

* deprecations

* chore: bump to nightly-2025-04-10

* chore: `Option.zipWith` -> `Option.merge`

* lake update

* toolchain

* fix

* fix

* Update lean-toolchain for testing leanprover/lean4#7897

* Trigger CI for leanprover/lean4#7897

* fix

* lake update and fix

* Fix

* Fix

* Trigger CI for leanprover/lean4#7897

* fix merge

* chore: adaptations for nightly-2025-04-10

* chore: bump to nightly-2025-04-14

* fix

* .

* annotate changed goal state

* fixes (adaptation notes)

* cleanup imports

* cleanup

* Update lean-toolchain for testing leanprover/lean4#7933

* Fix

* Fix

* Update lean-toolchain for testing leanprover/lean4#7975

* remove adaptation notes

* chore: bump to nightly-2025-04-16

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Markus Himmel <markus@lean-fro.org>
Co-authored-by: Rob23oba <robin.arnez@web.de>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: github-actions <github-actions@github.com>
@TwoFX TwoFX deleted the markus/int-bmod-1 branch August 4, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant