Skip to content

feat: grind internal CommRing class#7797

Merged
Kha merged 6 commits intomasterfrom
grind_commring
Apr 3, 2025
Merged

feat: grind internal CommRing class#7797
Kha merged 6 commits intomasterfrom
grind_commring

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Apr 3, 2025

This PR adds a monolithic CommRing class, for internal use by grind, and includes instances for Int/BitVec/IntX/UIntX.

@kim-em kim-em added the changelog-language Language features and metaprograms label Apr 3, 2025
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 3, 2025
@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Apr 3, 2025
@ghost
Copy link
Copy Markdown

ghost commented Apr 3, 2025

@ghost
Copy link
Copy Markdown

ghost commented Apr 3, 2025

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 3, 2025
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Apr 3, 2025
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 3, 2025
kim-em added a commit to leanprover-community/batteries that referenced this pull request Apr 3, 2025
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Apr 3, 2025
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 3, 2025
@ghost
Copy link
Copy Markdown

ghost commented Apr 3, 2025

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 3, 2025 02:05 Inactive
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Apr 3, 2025
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 3, 2025
@ghost
Copy link
Copy Markdown

ghost commented Apr 3, 2025

@ghost ghost removed the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Apr 3, 2025
@ghost
Copy link
Copy Markdown

ghost commented Apr 3, 2025

@ghost ghost added the builds-mathlib CI has verified that Mathlib builds against this PR label Apr 3, 2025
@leodemoura leodemoura added this pull request to the merge queue Apr 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2025
@Kha Kha added this pull request to the merge queue Apr 3, 2025
Merged via the queue into master with commit 196d899 Apr 3, 2025
22 of 23 checks passed
kmill added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 19, 2025
* fixes

* fix test

* fix

* chore: adaptations for leanprover/lean4#7797

* stricter rfl check

* fix merge

* Trigger CI for leanprover/lean4#7797

* Trigger CI for leanprover/lean4#7797

* Trigger CI for leanprover/lean4#7797

* inverse construction

* Update lean-toolchain for testing leanprover/lean4#7791

* lake update

* Fix

* Fix

* Fix

* chore: bump to nightly-2025-04-03

* more fixes

* merge lean-pr-testing-6325

* bump proofwidgets

* Update lean-toolchain for testing leanprover/lean4#7812

* shake

* fix shake

* fix tests

* import mathlib.init

* Update lean-toolchain for testing leanprover/lean4#7816

* Trigger CI for leanprover/lean4#7816

* Update lean-toolchain for testing leanprover/lean4#7802

* Fix

* fixes

* Fix (pending upstream changes)

* Trigger CI for leanprover/lean4#7802

* fix

* chore: bump to nightly-2025-04-04

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Update lean-toolchain for testing leanprover/lean4#7818

* Fix

* Fix

* Fix

* Merge master into nightly-testing

* Fix

* Fix comments

* fixes

* Trigger CI for leanprover/lean4#7816

* fix

* fix

* missing doc-string?

* chore: bump to nightly-2025-04-05

* chore: bump to nightly-2025-04-06

* move Batteries to nightly-testing

* lake update

* lint

* fix

* chore: bump to nightly-2025-04-07

* sprinkle noncomputable

* fix: relativize file paths

fix for leanprover/lean4#7822

* chore: reset cache

* chore: bump to nightly-2025-04-07

* shake

* fix: relativize more

* Update lean-toolchain for testing leanprover/lean4#7856

* Update lean-toolchain for testing leanprover/lean4#7851

* Fix

* Fix

* Fix

* Fix

* chore: bump to nightly-2025-04-08

* Update lean-toolchain for testing leanprover/lean4#7870

* Trigger CI for leanprover/lean4#7870

* Trigger CI for leanprover/lean4#7870

* Trigger CI for leanprover/lean4#7870

* wip

* Trigger CI for leanprover/lean4#7870

* .

* chore: bump to nightly-2025-04-09

* Trigger CI for leanprover/lean4#7870

* .

* bump

* lake update

* fixes for leanprover/lean4#7873

* fixes

* deprecations

* chore: bump to nightly-2025-04-10

* chore: `Option.zipWith` -> `Option.merge`

* lake update

* toolchain

* fix

* fix

* Update lean-toolchain for testing leanprover/lean4#7897

* Trigger CI for leanprover/lean4#7897

* fix

* lake update and fix

* Fix

* Fix

* Trigger CI for leanprover/lean4#7897

* fix merge

* chore: adaptations for nightly-2025-04-10

* chore: bump to nightly-2025-04-14

* fix

* .

* annotate changed goal state

* fixes (adaptation notes)

* cleanup imports

* cleanup

* Update lean-toolchain for testing leanprover/lean4#7933

* Fix

* Fix

* Update lean-toolchain for testing leanprover/lean4#7975

* remove adaptation notes

* chore: bump to nightly-2025-04-16

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Markus Himmel <markus@lean-fro.org>
Co-authored-by: Rob23oba <robin.arnez@web.de>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants