fix: search path related bugs#7873
Merged
mhuisi merged 10 commits intoleanprover:masterfrom Apr 9, 2025
Merged
Conversation
|
Mathlib CI status (docs):
|
797129d to
5607111
Compare
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit e1c9ee4. Benchmark Metric Change
===============================================================================
- Init.Data.List.Sublist async task-clock 2.8% (14.2 σ)
- Init.Data.List.Sublist re-elab -j4 wall-clock 3.2% (10.2 σ)
- Init.Prelude async wall-clock 2.8% (33.1 σ)
+ bv_decide_mul maxrss -2.2% (-27.5 σ)
- bv_decide_realworld wall-clock 1.7% (13.5 σ)
+ lake build no-op wall-clock -1.6% (-10.7 σ)
- omega_stress.lean async task-clock 3.5% (10.5 σ)
- omega_stress.lean async wall-clock 3.9% (13.4 σ)
- qsort task-clock 10.4% (69.3 σ)
- qsort wall-clock 10.4% (68.9 σ)
+ rbmap task-clock -3.5% (-10.7 σ)
+ rbmap wall-clock -3.5% (-11.0 σ)
- rbmap_fbip task-clock 2.7% (10.9 σ)
- rbmap_fbip wall-clock 2.7% (10.7 σ)
- reduceMatch maxrss 2.8% (35.9 σ)
- reduceMatch task-clock 1.5% (32.6 σ)
+ simp_arith1 task-clock -3.4% (-11.2 σ)
- stdlib instantiate metavars 2.8% (10.7 σ)
+ stdlib maxrss -2.2% (-62.4 σ)
- stdlib process pre-definitions 1.0% (10.2 σ)
- stdlib type checking 1.6% (10.9 σ)
- stdlib wall-clock 1.8% (20.0 σ)
+ unionfind task-clock -7.7% (-12.5 σ)
+ unionfind wall-clock -7.7% (-12.3 σ) |
kim-em
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 10, 2025
kim-em
added a commit
to leanprover-community/import-graph
that referenced
this pull request
Apr 10, 2025
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 10, 2025
kmill
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 19, 2025
* fixes * fix test * fix * chore: adaptations for leanprover/lean4#7797 * stricter rfl check * fix merge * Trigger CI for leanprover/lean4#7797 * Trigger CI for leanprover/lean4#7797 * Trigger CI for leanprover/lean4#7797 * inverse construction * Update lean-toolchain for testing leanprover/lean4#7791 * lake update * Fix * Fix * Fix * chore: bump to nightly-2025-04-03 * more fixes * merge lean-pr-testing-6325 * bump proofwidgets * Update lean-toolchain for testing leanprover/lean4#7812 * shake * fix shake * fix tests * import mathlib.init * Update lean-toolchain for testing leanprover/lean4#7816 * Trigger CI for leanprover/lean4#7816 * Update lean-toolchain for testing leanprover/lean4#7802 * Fix * fixes * Fix (pending upstream changes) * Trigger CI for leanprover/lean4#7802 * fix * chore: bump to nightly-2025-04-04 * Fix * Fix * Fix * Fix * Fix * Fix * Update lean-toolchain for testing leanprover/lean4#7818 * Fix * Fix * Fix * Merge master into nightly-testing * Fix * Fix comments * fixes * Trigger CI for leanprover/lean4#7816 * fix * fix * missing doc-string? * chore: bump to nightly-2025-04-05 * chore: bump to nightly-2025-04-06 * move Batteries to nightly-testing * lake update * lint * fix * chore: bump to nightly-2025-04-07 * sprinkle noncomputable * fix: relativize file paths fix for leanprover/lean4#7822 * chore: reset cache * chore: bump to nightly-2025-04-07 * shake * fix: relativize more * Update lean-toolchain for testing leanprover/lean4#7856 * Update lean-toolchain for testing leanprover/lean4#7851 * Fix * Fix * Fix * Fix * chore: bump to nightly-2025-04-08 * Update lean-toolchain for testing leanprover/lean4#7870 * Trigger CI for leanprover/lean4#7870 * Trigger CI for leanprover/lean4#7870 * Trigger CI for leanprover/lean4#7870 * wip * Trigger CI for leanprover/lean4#7870 * . * chore: bump to nightly-2025-04-09 * Trigger CI for leanprover/lean4#7870 * . * bump * lake update * fixes for leanprover/lean4#7873 * fixes * deprecations * chore: bump to nightly-2025-04-10 * chore: `Option.zipWith` -> `Option.merge` * lake update * toolchain * fix * fix * Update lean-toolchain for testing leanprover/lean4#7897 * Trigger CI for leanprover/lean4#7897 * fix * lake update and fix * Fix * Fix * Trigger CI for leanprover/lean4#7897 * fix merge * chore: adaptations for nightly-2025-04-10 * chore: bump to nightly-2025-04-14 * fix * . * annotate changed goal state * fixes (adaptation notes) * cleanup imports * cleanup * Update lean-toolchain for testing leanprover/lean4#7933 * Fix * Fix * Update lean-toolchain for testing leanprover/lean4#7975 * remove adaptation notes * chore: bump to nightly-2025-04-16 --------- Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Kim Morrison <kim@tqft.net> Co-authored-by: Markus Himmel <markus@lean-fro.org> Co-authored-by: Rob23oba <robin.arnez@web.de> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of bugs related to the handling of the source search path in the language server, where deleting files could cause several features to stop functioning and both untitled files and files that don't exist on disc could have conflicting module names.
In detail, it makes the following adjustments:
.leanfiles yield a«external:<full uri>»module name.Server.documentUriFromModule?andmoduleFromDocumentUrito ensure that we don't have minor deviations for this conversion all over the place.lake setup-file) is removed. It turns out thatlake servealready sets the correct source search path in the environment, so we can just always use the search path from the environment.$/lean/waitForILeansrequest that tests can use to wait for all .ilean files to be loaded and for the ilean references from the file worker for the current document version to be finalized.Breaking changes
Server.documentUriFromModulehas been renamed toServer.documentUriFromModule?and doesn't take aSearchPathargument anymore, as theSearchPathis now computed from theLEAN_SRC_PATHenvironment variable. It has also been moved fromLean.Server.GoTotoLean.Server.Utils.Server.moduleFromDocumentUridoes not take aSearchPathargument anymore and won't return anOptionanymore. It has also been moved fromLean.Server.GoTotoLean.Server.Utils.System.SearchPath.searchModuleNameOfUrifunction has been removed. It is recommended to useServer.moduleFromDocumentUriinstead.initSrcSearchPathfunction has been renamed togetSrcSearchPathand has been moved fromLean.Util.PathstoLean.Util.Path. It also doesn't need to take apkgSearchPathargument anymore.