feat(l1): remove experimental-discv5 feature flag and enable discv5 by default#6015
Merged
Conversation
**Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #5574 and #5575. Co-authored-by: Esteban Dimitroff Hodi <esteban.dimitroff@lambdaclass.com>
**Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #issue_number
**Motivation** I saw current new_nonce impl allocated a vector when it can just return a fixed size array. **Description** Removes the needless vec **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync.
**Motivation** In order to start merging discv5 code into main, to avoid having a huge PR at the end of the development, we should create a feature flag disabled by default. Closes #5639
**Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync.
**Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #5570 Closes #5571
…mental-feature-flag
…lambdaclass/ethrex into discv5-remove-experimental-feature-flag
…lambdaclass/ethrex into discv5-remove-experimental-feature-flag
…lambdaclass/ethrex into discv5-remove-experimental-feature-flag
ilitteri
approved these changes
Mar 4, 2026
azteca1998
approved these changes
Mar 4, 2026
edg-l
approved these changes
Mar 4, 2026
lakshya-sky
pushed a commit
to lakshya-sky/ethrex
that referenced
this pull request
Mar 10, 2026
…y default (lambdaclass#6015) **Motivation** Make discv5 a standard part of the networking stack instead of an experimental feature, enabling dual protocol discovery by default. **Description** - Remove the `experimental-discv5` feature flag from both `ethrex-p2p` and `ethrex` crates - Make `aes-gcm` and `hkdf` regular (non-optional) dependencies - Remove all `#[cfg(feature = "experimental-discv5")]` conditional compilation - Enable discv5 by default (both protocols now run simultaneously) - Update CLI help text to remove "(experimental)" label Closes lambdaclass#5971 --------- Co-authored-by: MrAzteca <azteca1998@users.noreply.github.com> Co-authored-by: Edgar <git@edgl.dev> Co-authored-by: Lucas Fiegl <iovoid@users.noreply.github.com> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> Co-authored-by: Pablo Deymonnaz <pdeymon@fi.uba.ar>
Muzry
pushed a commit
to Muzry/ethrex
that referenced
this pull request
Mar 17, 2026
…y default (lambdaclass#6015) **Motivation** Make discv5 a standard part of the networking stack instead of an experimental feature, enabling dual protocol discovery by default. **Description** - Remove the `experimental-discv5` feature flag from both `ethrex-p2p` and `ethrex` crates - Make `aes-gcm` and `hkdf` regular (non-optional) dependencies - Remove all `#[cfg(feature = "experimental-discv5")]` conditional compilation - Enable discv5 by default (both protocols now run simultaneously) - Update CLI help text to remove "(experimental)" label Closes lambdaclass#5971 --------- Co-authored-by: MrAzteca <azteca1998@users.noreply.github.com> Co-authored-by: Edgar <git@edgl.dev> Co-authored-by: Lucas Fiegl <iovoid@users.noreply.github.com> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> Co-authored-by: Pablo Deymonnaz <pdeymon@fi.uba.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make discv5 a standard part of the networking stack instead of an experimental feature, enabling dual protocol discovery by default.
Description
experimental-discv5feature flag from bothethrex-p2pandethrexcratesaes-gcmandhkdfregular (non-optional) dependencies#[cfg(feature = "experimental-discv5")]conditional compilationCloses #5971