Skip to content

feat(l1): implement discv5's FindNode message#5629

Merged
edg-l merged 2 commits into
discv5from
discv5_findnode_coding
Dec 15, 2025
Merged

feat(l1): implement discv5's FindNode message#5629
edg-l merged 2 commits into
discv5from
discv5_findnode_coding

Conversation

@edg-l

@edg-l edg-l commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Checklist

  • Updated STORE_SCHEMA_VERSION (crates/storage/lib.rs) if the PR includes breaking changes to the Store requiring a re-sync.

Closes #5576 and closes #5577

@edg-l edg-l requested a review from a team as a code owner December 15, 2025 07:44
@github-actions github-actions Bot added the L1 Ethereum client label Dec 15, 2025
@github-actions

github-actions Bot commented Dec 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Lines of code report

Total lines added: 35
Total lines removed: 1
Total lines changed: 36

Detailed view 
+-------------------------------------------------+-------+------+
| File                                            | Lines | Diff |
+-------------------------------------------------+-------+------+
| ethrex/crates/common/types/transaction.rs       | 3237  | -1   |
+-------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/discv5/messages.rs | 516   | +35  |
+-------------------------------------------------+-------+------+

@github-project-automation github-project-automation Bot moved this to In Review in ethrex_l1 Dec 15, 2025
@edg-l edg-l force-pushed the discv5_findnode_coding branch from b5c9048 to 81919af Compare December 15, 2025 12:19
@edg-l edg-l merged commit d2da66c into discv5 Dec 15, 2025
13 of 14 checks passed
@edg-l edg-l deleted the discv5_findnode_coding branch December 15, 2025 12:54
@github-project-automation github-project-automation Bot moved this from In Review to Done in ethrex_l1 Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElFantasma ElFantasma ElFantasma approved these changes

@ilitteri ilitteri Awaiting requested review from ilitteri

@ManuelBilbao ManuelBilbao Awaiting requested review from ManuelBilbao

@avilagaston9 avilagaston9 Awaiting requested review from avilagaston9

+1 more reviewer

@azteca1998 azteca1998 azteca1998 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@edg-l edg-l

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edg-l @azteca1998 @ElFantasma