Skip to content

chore(l1): put all discv5 behind a feature flag#5651

Merged
ElFantasma merged 1 commit into
discv5from
discv5_feature
Dec 16, 2025
Merged

chore(l1): put all discv5 behind a feature flag#5651
ElFantasma merged 1 commit into
discv5from
discv5_feature

Conversation

@edg-l

@edg-l edg-l commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Motivation

In order to start merging discv5 code into main, to avoid having a huge PR at the end of the development, we should create a feature flag disabled by default.

Closes #5639

@edg-l edg-l requested a review from a team as a code owner December 16, 2025 09:21
@github-actions github-actions Bot added the L1 Ethereum client label Dec 16, 2025
@edg-l edg-l linked an issue Dec 16, 2025 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown

Lines of code report

Total lines added: 1
Total lines removed: 0
Total lines changed: 1

Detailed view
+-------------------------------------+-------+------+
| File                                | Lines | Diff |
+-------------------------------------+-------+------+
| ethrex/crates/networking/p2p/p2p.rs | 15    | +1   |
+-------------------------------------+-------+------+

@github-project-automation github-project-automation Bot moved this to In Review in ethrex_l1 Dec 16, 2025
@ElFantasma ElFantasma merged commit 13b1e16 into discv5 Dec 16, 2025
42 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in ethrex_l1 Dec 16, 2025
@ElFantasma ElFantasma deleted the discv5_feature branch December 16, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Put all discv5 behind a feature flag

2 participants