fix: revert "fix: remove totalDifficulty (#347)" #566
Merged
Conversation
This reverts commit a66dc76.
mpaulucci
approved these changes
Sep 26, 2024
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in #304 and reintroduced in #566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
JereSalo
pushed a commit
that referenced
this pull request
Feb 28, 2025
#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in #304 and reintroduced in #566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
fkrause98
pushed a commit
that referenced
this pull request
Mar 5, 2025
#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in #304 and reintroduced in #566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
fkrause98
pushed a commit
that referenced
this pull request
Mar 5, 2025
#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in #304 and reintroduced in #566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
lambdaclass#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in lambdaclass#304 and reintroduced in lambdaclass#566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Description** This PR fully removes `total_difficulty` field, as already done on lambdaclass#307, but later reverted on lambdaclass#566. While doing so, it also removes the `total_difficulty_check` function, so it solves lambdaclass#790 Closes lambdaclass#790 --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While the rpc-compat tests can be made to work without the totalDifficulty field by updating the execution api crate, the engine tests panick as they still rely on it.
This PR aims to fix this issue (at least until the hive engine test suite is updated) by reverting the removal of the field and using a previous version of the execution api crate which still has this field
execution-apisbeforetotalDifficutlyfield removal hive#6)Closes None, but is needed in order to run engine tests