Skip to content

chore(l1): remove total_difficulty#2052

Merged
JulianVentura merged 5 commits into
mainfrom
fix/remove-total-difficulty
Feb 25, 2025
Merged

chore(l1): remove total_difficulty#2052
JulianVentura merged 5 commits into
mainfrom
fix/remove-total-difficulty

Conversation

@JulianVentura

@JulianVentura JulianVentura commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fully removes total_difficulty field, as already done on #307, but later reverted on #566.
While doing so, it also removes the total_difficulty_check function, so it solves #790

Closes #790

@JulianVentura JulianVentura requested a review from a team as a code owner February 21, 2025 19:48
@github-actions

github-actions Bot commented Feb 21, 2025 •
edited
Loading

Copy link
Copy Markdown 
| File                                                                       | Lines | Diff |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/fork_choice.rs           | 139   | -40  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/api.rs                | 195   | -12  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/rlp.rs                | 88    | -2   |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/store.rs              | 1247  | -25  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/store_db/in_memory.rs | 481   | -35  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/store_db/libmdbx.rs   | 890   | -37  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/store_db/redb.rs      | 873   | -45  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/utils.rs              | 52    | -4   |
+----------------------------------------------------------------------------+-------+------+

Total lines added: 0
Total lines removed: 200
Total lines changed: 200

mpaulucci
mpaulucci requested changes Feb 21, 2025
View reviewed changes

@mpaulucci mpaulucci left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this until we're sure it doesn't bring any regressions.

In mainnet this could be an issue since we have to deal with pre merge blocks.

mpaulucci
mpaulucci approved these changes Feb 24, 2025
View reviewed changes

@mpaulucci mpaulucci left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the approach on this. Let's merge it, and if we find an issue, we can revert it.

avilagaston9
avilagaston9 approved these changes Feb 24, 2025
View reviewed changes
Comment thread crates/storage/store/utils.rs Outdated
@JulianVentura JulianVentura added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 1f21274 Feb 25, 2025
@JulianVentura JulianVentura deleted the fix/remove-total-difficulty branch February 25, 2025 15:28
JereSalo pushed a commit that referenced this pull request Feb 28, 2025
@JulianVentura @JereSalo
chore(l1): remove total_difficulty (#2052)
f158abe 
**Description**

This PR fully removes `total_difficulty` field, as already done on #307,
but later reverted on #566.
While doing so, it also removes the `total_difficulty_check` function,
so it solves #790

Closes #790

---------

Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
fkrause98 pushed a commit that referenced this pull request Mar 5, 2025
@JulianVentura @fkrause98
chore(l1): remove total_difficulty (#2052)
975c1b7 
**Description**

This PR fully removes `total_difficulty` field, as already done on #307,
but later reverted on #566.
While doing so, it also removes the `total_difficulty_check` function,
so it solves #790

Closes #790

---------

Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
fkrause98 pushed a commit that referenced this pull request Mar 5, 2025
@JulianVentura @fkrause98
chore(l1): remove total_difficulty (#2052)
cdb8c38 
**Description**

This PR fully removes `total_difficulty` field, as already done on #307,
but later reverted on #566.
While doing so, it also removes the `total_difficulty_check` function,
so it solves #790

Closes #790

---------

Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
pedrobergamini pushed a commit to pedrobergamini/ethrex that referenced this pull request Aug 24, 2025
@JulianVentura
chore(l1): remove total_difficulty (lambdaclass#2052)
3476759 
**Description**

This PR fully removes `total_difficulty` field, as already done on lambdaclass#307,
but later reverted on lambdaclass#566.
While doing so, it also removes the `total_difficulty_check` function,
so it solves lambdaclass#790

Closes lambdaclass#790

---------

Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

+1 more reviewer

@avilagaston9 avilagaston9 avilagaston9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Evaluate the total difficulty check

3 participants

@JulianVentura @mpaulucci @avilagaston9