fix(l1): update rpc-compat hive tests to Prague and fix failing ones#2043
Merged
Conversation
added 2 commits
February 20, 2025 15:36
|
total_difficulty and fix nonce serializationrpc-compat hive tests to Prague and fix failing ones
mpaulucci
reviewed
Feb 21, 2025
| - name: "Rpc Compat tests" | ||
| simulation: ethereum/rpc-compat | ||
| test_pattern: /eth_chainId|eth_getTransactionByBlockHashAndIndex|eth_getTransactionByBlockNumberAndIndex|eth_getCode|eth_getStorageAt|eth_call|eth_getTransactionByHash|eth_getBlockByHash|eth_getBlockByNumber|eth_createAccessList|eth_getBlockTransactionCountByNumber|eth_getBlockTransactionCountByHash|eth_getBlockReceipts|eth_getTransactionReceipt|eth_blobGasPrice|eth_blockNumber|ethGetTransactionCount|debug_getRawHeader|debug_getRawBlock|debug_getRawTransaction|debug_getRawReceipts|eth_estimateGas|eth_getBalance|eth_sendRawTransaction|eth_getProof|eth_getLogs|eth_syncing | ||
| test_pattern: /debug_getRawBlock|debug_getRawHeader|debug_getRawReceipts|debug_getRawTransaction|eth_blobBaseFee|eth_blockNumber|eth_call|eth_chainId|eth_createAccessList|eth_estimateGas|eth_getBalance|eth_getBlockByHash|eth_getBlockByNumber|eth_getBlockReceipts|eth_getBlockTransactionCountByHash|eth_getBlockTransactionCountByNumber|eth_getCode|eth_getLogs|eth_getProof|eth_getStorageAt|eth_getTransactionByBlockHashAndIndex|eth_getTransactionByBlockNumberAndIndex|eth_getTransactionByHash|eth_getTransactionCount|eth_getTransactionReceipt|eth_sendRawTransaction|eth_syncing |
Collaborator
There was a problem hiding this comment.
If I understand correctly, we would pass all tests now. Cant we remove test pattern then?
Contributor
Author
There was a problem hiding this comment.
Not yet, we are still missing feeHistory test, which will be added on #1797. That PR depends on this one in order to be merged!
mpaulucci
reviewed
Feb 21, 2025
| Ok(None) | ||
| } | ||
|
|
||
| fn total_difficulty_check<'a>( |
Collaborator
There was a problem hiding this comment.
At some point we removed total difficulty, but we had to reintroduce it again, I can't remember why. @avilagaston9 do you remember?
Otherwise, love the red!
Contributor
There was a problem hiding this comment.
I wasn't in the project when it was added again. But maybe we shouldn't remove this check, it was added here: #577. Maybe we should just skip serializing instead.
mpaulucci
approved these changes
Feb 21, 2025
mpaulucci
left a comment
Collaborator
There was a problem hiding this comment.
🚀 +1 pending Gaston's confirmation
added 3 commits
February 21, 2025 14:34
mpaulucci
approved these changes
Feb 21, 2025
JereSalo
pushed a commit
that referenced
this pull request
Feb 28, 2025
#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in #304 and reintroduced in #566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
fkrause98
pushed a commit
that referenced
this pull request
Mar 5, 2025
#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in #304 and reintroduced in #566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
fkrause98
pushed a commit
that referenced
this pull request
Mar 5, 2025
#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in #304 and reintroduced in #566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
lambdaclass#2043) **Description** This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the `total_difficulty` field on the block scheme. This field was already removed in lambdaclass#304 and reintroduced in lambdaclass#566 due to the usage in hive engine test suite. Hive tests related to the wrong encoding of `nonce` field were also fixed --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the hive tests suite to a new hive revision and fixes new tests by removing the
total_difficultyfield on the block scheme. This field was already removed in #304 and reintroduced in #566 due to the usage in hive engine test suite.Hive tests related to the wrong encoding of
noncefield were also fixed