fix(l1): modify the RPC eth_feeHistory controller implementation#1797
Merged
Conversation
|
ilitteri
reviewed
Jan 24, 2025
ilitteri
reviewed
Jan 24, 2025
ilitteri
reviewed
Jan 24, 2025
ilitteri
left a comment
Collaborator
There was a problem hiding this comment.
The PR looks good, left a couple of nits. It'd be nice to add which tests that were not passing are doing it because of these changes.
eth_feeHistory controller implementationeth_feeHistory controller implementation
avilagaston9
approved these changes
Feb 24, 2025
JereSalo
pushed a commit
that referenced
this pull request
Feb 28, 2025
…1797) **Description** This PR fixes the implementation of the `eth_feeHistory` RPC endpoint, by adding some new validations and modifying how the projected values of `base_fee_per_gas` and `base_fee_per_blob` are obtained. --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
fkrause98
pushed a commit
that referenced
this pull request
Mar 5, 2025
…1797) **Description** This PR fixes the implementation of the `eth_feeHistory` RPC endpoint, by adding some new validations and modifying how the projected values of `base_fee_per_gas` and `base_fee_per_blob` are obtained. --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
fkrause98
pushed a commit
that referenced
this pull request
Mar 5, 2025
…1797) **Description** This PR fixes the implementation of the `eth_feeHistory` RPC endpoint, by adding some new validations and modifying how the projected values of `base_fee_per_gas` and `base_fee_per_blob` are obtained. --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
1 task
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…ambdaclass#1797) **Description** This PR fixes the implementation of the `eth_feeHistory` RPC endpoint, by adding some new validations and modifying how the projected values of `base_fee_per_gas` and `base_fee_per_blob` are obtained. --------- Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the implementation of the
eth_feeHistoryRPC endpoint, by adding some new validations and modifying how the projected values ofbase_fee_per_gasandbase_fee_per_blobare obtained.