Skip to content

Update what-is-kubernetes.md#11399

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
kchekuru:patch-3
Nov 29, 2018
Merged

Update what-is-kubernetes.md#11399
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
kchekuru:patch-3

Conversation

@kchekuru
Copy link
Copy Markdown
Contributor

@kchekuru kchekuru commented Nov 29, 2018

fat is offensive

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please delete this note before submitting the pull request.

For 1.13 Features: set Milestone to 1.13 and Base Branch to dev-1.13

Help editing and submitting pull requests:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

Help choosing which branch to use:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 29, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 29, 2018
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Nov 29, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d17e460

https://deploy-preview-11399--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 29, 2018
@bgrant0607
Copy link
Copy Markdown
Member

bgrant0607 commented Nov 29, 2018

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@bgrant0607 bgrant0607 mentioned this pull request Nov 29, 2018
Closed
@kchekuru
Copy link
Copy Markdown
Contributor Author

kchekuru commented Nov 29, 2018

/assign @cody-clark

@cody-clark
Copy link
Copy Markdown
Contributor

cody-clark commented Nov 29, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@cody-clark cody-clark mentioned this pull request Nov 29, 2018
Closed
@chenrui333 chenrui333 mentioned this pull request Nov 29, 2018
Closed
@k8s-ci-robot k8s-ci-robot merged commit a81ba11 into kubernetes:master Nov 29, 2018
@cody-clark
Copy link
Copy Markdown
Contributor

cody-clark commented Nov 29, 2018

Hey, @chenrui333, sorry I saw this lgtm-ed before I saw your comments on the duplicate PR. Do you want me to revert this and continue the discussion?

@chenrui333
Copy link
Copy Markdown
Member

chenrui333 commented Nov 29, 2018

hi @cody-clark, Thanks for checking back on this. I can actually go either way. 😄

But I just want to point out it is very descriptive, and has been used in the other domain as well.

chenrui333 added a commit that referenced this pull request Dec 3, 2018
@chenrui333
Merge branch 'master' of git://github.com/kubernetes/website into rel…
6e094fa 
…ease-1.12

* 'master' of git://github.com/kubernetes/website: (222 commits)
  Add temporary owners for 1.13 release (#11453)
  fix Minikube 404 error. (#11461)
  Resolve conflicts against dev-1.13 for /ko contents (#11439)
  replace `run` with `create deployment` (#11392)
  Updated list all pods with -o wide comment (#11394)
  fix broken link for KubeletConfiguration (#11423)
  Update on pod-priority-preemption.md (#11418)
  Add guidelines for working with localized content (#11415)
  Update what-is-kubernetes.md (#11399)
  Remove redundant close tags and little bit formatting (#11389)
  Add SysEleven MetaKube as hosted solution (#11393)
  Add rui to sig-docs-zh team (#11391)
  fix Improper translation (#11384)
  Add pigletfly(WangBing) as a sig-docs-zh-reviewer (#11370)
  update link to CloudProvider Interface (#11228)
  Fix the "my-scheduler-as-kube-scheduler" ClusterRoleBinding. (#11112)
  fix non-existing "CloudProvider Interface" link (#10953)
  Updated ingress.md (#11213)
  Further updates to TLS Bootstrapping (#11258)
  Updated 'exec' description (#11365)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@bgrant0607 bgrant0607

@cody-clark cody-clark

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kchekuru @k8s-ci-robot @k8sio-netlify-preview-bot @bgrant0607 @cody-clark @chenrui333