Skip to content

replace run with create deployment#11392

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
davidkazuhiro:patch-1
Nov 30, 2018
Merged

replace run with create deployment#11392
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
davidkazuhiro:patch-1

Conversation

@davidkazuhiro
Copy link
Copy Markdown
Contributor

@davidkazuhiro davidkazuhiro commented Nov 29, 2018

because kubectl run is deprecated

$ kubectl run ...
kubectl run --generator=deployment/apps.v1beta1 is DEPRECATED and will be removed in a future version. Use kubectl create instead.

because `kubectl run` is deprecated
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 29, 2018
@davidkazuhiro
Copy link
Copy Markdown
Contributor Author

/assign @zacharysarah

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Nov 29, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit eba0d73

https://deploy-preview-11392--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Nov 29, 2018
@Bradamant3
Copy link
Copy Markdown
Contributor

@davidkazuhiro thanks very much for your PR! Could you please separate this one out into two PRs, one for en and one for ko? We have different approvers for the different language directories. (And yes, we need to document this fact better for new contributors! Thanks for your patience while we work out the bugs in the new localization process.)

/hold
/assign

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2018
@davidkazuhiro
Copy link
Copy Markdown
Contributor Author

Ah sorry @Bradamant3 I assumed that both sets of CODEOWNERS would review the same PR.
I've removed the korean files.

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Nov 30, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2018
@cody-clark
Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2018
@cody-clark
Copy link
Copy Markdown
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1e933a1 into kubernetes:master Nov 30, 2018
@davidkazuhiro davidkazuhiro deleted the patch-1 branch November 30, 2018 23:29
davidkazuhiro added a commit to davidkazuhiro/website that referenced this pull request Nov 30, 2018
"run" is deprecated and "create deployment" is preferred
so the english doc was updated in kubernetes#11392

this pr reflects that change in the korean translation
chenrui333 added a commit that referenced this pull request Dec 3, 2018
…ease-1.12

* 'master' of git://github.com/kubernetes/website: (222 commits)
  Add temporary owners for 1.13 release (#11453)
  fix Minikube 404 error. (#11461)
  Resolve conflicts against dev-1.13 for /ko contents (#11439)
  replace `run` with `create deployment` (#11392)
  Updated list all pods with -o wide comment (#11394)
  fix broken link for KubeletConfiguration (#11423)
  Update on pod-priority-preemption.md (#11418)
  Add guidelines for working with localized content (#11415)
  Update what-is-kubernetes.md (#11399)
  Remove redundant close tags and little bit formatting (#11389)
  Add SysEleven MetaKube as hosted solution (#11393)
  Add rui to sig-docs-zh team (#11391)
  fix Improper translation (#11384)
  Add pigletfly(WangBing) as a sig-docs-zh-reviewer (#11370)
  update link to CloudProvider Interface (#11228)
  Fix the "my-scheduler-as-kube-scheduler" ClusterRoleBinding. (#11112)
  fix non-existing "CloudProvider Interface" link (#10953)
  Updated ingress.md (#11213)
  Further updates to TLS Bootstrapping (#11258)
  Updated 'exec' description (#11365)
  ...
k8s-ci-robot pushed a commit that referenced this pull request Dec 7, 2018
"run" is deprecated and "create deployment" is preferred
so the english doc was updated in #11392

this pr reflects that change in the korean translation
kychool pushed a commit to kychool/website that referenced this pull request Dec 26, 2018
"run" is deprecated and "create deployment" is preferred
so the english doc was updated in kubernetes#11392

this pr reflects that change in the korean translation
kychool pushed a commit to kychool/website that referenced this pull request Dec 26, 2018
"run" is deprecated and "create deployment" is preferred
so the english doc was updated in kubernetes#11392

this pr reflects that change in the korean translation
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
"run" is deprecated and "create deployment" is preferred
so the english doc was updated in kubernetes#11392

this pr reflects that change in the korean translation
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
"run" is deprecated and "create deployment" is preferred
so the english doc was updated in kubernetes#11392

this pr reflects that change in the korean translation
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
"run" is deprecated and "create deployment" is preferred
so the english doc was updated in kubernetes#11392

this pr reflects that change in the korean translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants