Skip to content

Updated ingress.md#11213

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
joost:patch-1
Nov 28, 2018
Merged

Updated ingress.md#11213
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
joost:patch-1

Conversation

@joost
Copy link
Copy Markdown
Contributor

@joost joost commented Nov 23, 2018

Typo serivceName in docs.

Updated ingress.md
0298840 
Typo serivceName.
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 23, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language labels Nov 23, 2018
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Nov 23, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b9e1186

https://deploy-preview-11213--kubernetes-io-master-staging.netlify.com

@xiangpengzhao
Copy link
Copy Markdown
Contributor

xiangpengzhao commented Nov 24, 2018

Good catch! Thanks for your contrtibution!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2018
@xiangpengzhao
Copy link
Copy Markdown
Contributor

xiangpengzhao commented Nov 24, 2018

Please sign your CLA :)

@joost
Copy link
Copy Markdown
Contributor Author

joost commented Nov 25, 2018

Signed. Not sure how to re-trigger checks.

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Nov 26, 2018

/check-cla

1 similar comment
@joost
Copy link
Copy Markdown
Contributor Author

joost commented Nov 27, 2018

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 27, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2018
@Bradamant3
Copy link
Copy Markdown
Contributor

Bradamant3 commented Nov 28, 2018

yes, thanks very much @joost !

fixed merge conflict and added a couple of minor copyedits.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit 795c418 into kubernetes:master Nov 28, 2018
chenrui333 added a commit that referenced this pull request Dec 3, 2018
@chenrui333
Merge branch 'master' of git://github.com/kubernetes/website into rel…
6e094fa 
…ease-1.12

* 'master' of git://github.com/kubernetes/website: (222 commits)
  Add temporary owners for 1.13 release (#11453)
  fix Minikube 404 error. (#11461)
  Resolve conflicts against dev-1.13 for /ko contents (#11439)
  replace `run` with `create deployment` (#11392)
  Updated list all pods with -o wide comment (#11394)
  fix broken link for KubeletConfiguration (#11423)
  Update on pod-priority-preemption.md (#11418)
  Add guidelines for working with localized content (#11415)
  Update what-is-kubernetes.md (#11399)
  Remove redundant close tags and little bit formatting (#11389)
  Add SysEleven MetaKube as hosted solution (#11393)
  Add rui to sig-docs-zh team (#11391)
  fix Improper translation (#11384)
  Add pigletfly(WangBing) as a sig-docs-zh-reviewer (#11370)
  update link to CloudProvider Interface (#11228)
  Fix the "my-scheduler-as-kube-scheduler" ClusterRoleBinding. (#11112)
  fix non-existing "CloudProvider Interface" link (#10953)
  Updated ingress.md (#11213)
  Further updates to TLS Bootstrapping (#11258)
  Updated 'exec' description (#11365)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bprashanth bprashanth Awaiting requested review from bprashanth

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@Bradamant3 Bradamant3

@xiangpengzhao xiangpengzhao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joost @k8s-ci-robot @k8sio-netlify-preview-bot @xiangpengzhao @tengqm @Bradamant3