Skip to content

fix bugs introduced by ipvs graceful termination#69268

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Lion-Wei:fix-graceful-termination
Sep 30, 2018
Merged

fix bugs introduced by ipvs graceful termination#69268
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Lion-Wei:fix-graceful-termination

Conversation

@Lion-Wei
Copy link
Copy Markdown

@Lion-Wei Lion-Wei commented Sep 30, 2018

What this PR does / why we need it:

fix bugs introduced by ipvs graceful termination, and ci is failing cause this problem.

https://k8s-testgrid.appspot.com/sig-network-gce#gci-gce-ipvs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69267

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2018
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2018
@Lion-Wei
Copy link
Copy Markdown
Author

Lion-Wei commented Sep 30, 2018

/assign @m1093782566
/cc @rramkumar1 @BenTheElder
PTAL, thanks.

@m1093782566
Copy link
Copy Markdown
Contributor

m1093782566 commented Sep 30, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2018
@m1093782566
Copy link
Copy Markdown
Contributor

m1093782566 commented Sep 30, 2018

/retest

@m1093782566
Copy link
Copy Markdown
Contributor

m1093782566 commented Sep 30, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lion-Wei, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Sep 30, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 30, 2018
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 30, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 30, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 6a8a859 into kubernetes:master Sep 30, 2018
This was referenced Oct 19, 2018
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 24, 2018
@k8s-ci-robot
Merge pull request #70006 from Lion-Wei/automated-cherry-pick-of-#68874-
ab427c8 
#66012-#69268-upstream-release-1.12

Automated cherry pick of #68874: update vendor #66012: ipvs support graceful termination #69268: fix bugs introduced by ipvs graceful termination
k8s-ci-robot added a commit that referenced this pull request Nov 8, 2018
@k8s-ci-robot
Merge pull request #70007 from Lion-Wei/automated-cherry-pick-of-#68874-
c2b5e95 
#66012-#69268-upstream-release-1.11

Automated cherry pick of #68874: update vendor #66012: ipvs support graceful termination #69268: fix bugs introduced by ipvs graceful termination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@thockin thockin Awaiting requested review from thockin

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@m1093782566 m1093782566

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing tests: gci-gce-ipvs

5 participants

@Lion-Wei @m1093782566 @k8s-ci-robot @BenTheElder @fejta-bot