Skip to content

Automated cherry pick of #68874: update vendor #66012: ipvs support graceful termination #69268: fix bugs introduced by ipvs graceful termination#70006

Merged
k8s-ci-robot merged 4 commits intokubernetes:release-1.12from
Lion-Wei:automated-cherry-pick-of-#68874-#66012-#69268-upstream-release-1.12
Oct 24, 2018
Merged

Automated cherry pick of #68874: update vendor #66012: ipvs support graceful termination #69268: fix bugs introduced by ipvs graceful termination#70006
k8s-ci-robot merged 4 commits intokubernetes:release-1.12from
Lion-Wei:automated-cherry-pick-of-#68874-#66012-#69268-upstream-release-1.12

Conversation

@Lion-Wei
Copy link
Copy Markdown

@Lion-Wei Lion-Wei commented Oct 19, 2018

Cherry pick of #68874 #66012 #69268 on release-1.12.

#68874: update vendor
#66012: ipvs support graceful termination
#69268: fix bugs introduced by ipvs graceful termination

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 19, 2018

@Lion-Wei: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2018
@k8s-ci-robot k8s-ci-robot requested a review from lavalamp October 19, 2018 07:41
@idealhack
Copy link
Copy Markdown
Contributor

idealhack commented Oct 21, 2018

/kind bug
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 21, 2018
@dghubble
Copy link
Copy Markdown
Contributor

dghubble commented Oct 21, 2018

Isn't this a new feature being cherry-picked into a point release? Since the original introduction in #66012 was breaking v1.13.0-alpha tests #69267.

@feiskyer
Copy link
Copy Markdown
Member

feiskyer commented Oct 22, 2018

@Lion-Wei @m1093782566 @sttts Please get the PR approved (with both lgtm and approved label) by end of Tuesday, Oct 23th. Or else, it will miss v1.12.2.

@m1093782566
Copy link
Copy Markdown
Contributor

m1093782566 commented Oct 22, 2018

@feiskyer

Thanks for your reminder.

/lgtm
/approve

@ping @sttts for cherry-pick approval.

@m1093782566
Copy link
Copy Markdown
Contributor

m1093782566 commented Oct 22, 2018

@feiskyer

Thanks for your reminder.

/lgtm
/approve

ping @sttts for cherry-pick approval.

1 similar comment
@m1093782566
Copy link
Copy Markdown
Contributor

m1093782566 commented Oct 22, 2018

@feiskyer

Thanks for your reminder.

/lgtm
/approve

ping @sttts for cherry-pick approval.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2018
@Lion-Wei
Copy link
Copy Markdown
Author

Lion-Wei commented Oct 23, 2018

/assign @lavalamp @sttts
PTAL, thanks.

@Lion-Wei
Copy link
Copy Markdown
Author

Lion-Wei commented Oct 23, 2018

@dghubble Actually it's not like a new feature, cause if kube-proxy don't support graceful termination, then if we delete a pod, will immediately lost the connection, that's kind of bug, I think.

Isn't this a new feature being cherry-picked into a point release?

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Oct 23, 2018

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lion-Wei, m1093782566, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit ab427c8 into kubernetes:release-1.12 Oct 24, 2018
@Lion-Wei Lion-Wei mentioned this pull request Oct 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@lavalamp lavalamp

@sttts sttts

@m1093782566 m1093782566

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Lion-Wei @k8s-ci-robot @idealhack @dghubble @feiskyer @m1093782566 @sttts @lavalamp