update vendor for ipvs graceful termination#68874
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Sep 27, 2018
Lion-Wei:ipvs-graceful-termination-vendor
Merged
update vendor for ipvs graceful termination#68874k8s-ci-robot merged 1 commit intokubernetes:masterfrom Lion-Wei:ipvs-graceful-termination-vendor
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Lion-Wei:ipvs-graceful-termination-vendor
Conversation
Author
|
/sig network |
Author
|
/assign @m1093782566 @sttts |
Contributor
|
/lgtm Can anyone approve this? |
Contributor
|
/approve |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Lion-Wei, m1093782566, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Is there a plan to cherry pick this back to 1.12 and/or 1.11 any time soon? |
Contributor
|
@Lion-Wei , do you know if this is going to be cherry picked back to 1.12 or 1.11? |
This was referenced Oct 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For now, ipvs proxy mode don't support graceful termination, when a pod be deleted, the connection will be lost immediately, Which my lead to serious problem in some case.
For more detail, see this issue. #57841
I raised a pr to solve this problem, for the sake of review, split vendor part here.
The complete pr is: #66012
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):xref: #57841
Special notes for your reviewer:
Update
github.com/docker/libnetwork/ipvsand related deps for ipvs support graceful termination.Release note: