Skip to content

vendor: bump runc to rc95#102147

Merged
k8s-ci-robot merged 4 commits intokubernetes:masterfrom
kolyshkin:update-runc-rc94-take-II
May 21, 2021
Merged

vendor: bump runc to rc95#102147
k8s-ci-robot merged 4 commits intokubernetes:masterfrom
kolyshkin:update-runc-rc94-take-II

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented May 19, 2021 •
edited by liggitt
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

#101989
Fixes: #100328
Fixes: #88197

Special notes for your reviewer:

This also carries a couple of commits from #100631, and a change from #98374.

The previous attempt to bump runc (#101888) was reverted (#102094) due to a failing test (#102092). We believe that picking up #98374 fixes that issue; please check
https://prow.k8s.io/?pull=102147&job=*pull-kubernetes-node-crio-e2e

Does this PR introduce a user-facing change?

Fix a kubelet CPU regression in 1.21 and fixes resource enforcement when using systemd cgroup driver

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 19, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 19, 2021

Hi @kolyshkin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2021
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented May 19, 2021

/test pull-kubernetes-node-crio-e2e

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 19, 2021

@kolyshkin: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-kubernetes-node-crio-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from a team, aojea and caesarxuchao May 19, 2021 17:11
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 19, 2021
@odinuge odinuge mentioned this pull request May 20, 2021
Closed
@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented May 20, 2021

@kolyshkin can you pls change description so the below bug will not automatically close:

Fixes: #101989

So we will track the work of back porting

@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented May 20, 2021

can you pls change description so the below bug will not automatically close:

Done

@bobbypage
Copy link
Copy Markdown
Member

bobbypage commented May 20, 2021 •
edited
Loading

I think we should preferably get node-kubelet-serial going again to verify for any regressions, see #102148. We should preferably have a test suite similar running with systemd cgroup driver as well. Maybe @harche could look at that as you have been working with those kinds of things, that would be fantastic!

another idea in the meantime is we can run this PR against subset of those tests manually for now. I think the main tests that look relevant are node_container_manager_test and container_manager_test

BenTheElder
BenTheElder approved these changes May 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor changes are LGTM

@ehashman
Copy link
Copy Markdown
Member

ehashman commented May 20, 2021

Re: #102147 (comment) I opened kubernetes/test-infra#22284 to add that job as a presubmit for cases like this.

Filed #102194 for failing alpha job.
/skip

@dims
Copy link
Copy Markdown
Member

dims commented May 20, 2021

/approve
/lgtm

/assign @liggitt @smarterclayton

@mrunalp
Copy link
Copy Markdown
Contributor

mrunalp commented May 20, 2021

/approve

@liggitt
Copy link
Copy Markdown
Member

liggitt commented May 20, 2021

This has the runc and test changes needed to pick back to 1.21?

@liggitt
Copy link
Copy Markdown
Member

liggitt commented May 20, 2021

/lgtm
/approve

@liggitt liggitt mentioned this pull request May 20, 2021
Merged
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, harche, kolyshkin, liggitt, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@ehashman
Copy link
Copy Markdown
Member

ehashman commented May 20, 2021

This has the runc and test changes needed to pick back to 1.21?

Next 2 commits make the new API work.

@kolyshkin kolyshkin mentioned this pull request May 20, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit 5de1a75 into kubernetes:master May 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 21, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 21, 2021

@kolyshkin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-alpha-features d312ef7 link /test pull-kubernetes-e2e-gce-alpha-features

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 21, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request May 21, 2021
@k8s-ci-robot
Merge pull request #102196 from kolyshkin/automated-cherry-pick-of-#1…
133f66a 
…02147-upstream-release-1.21

Automated cherry pick of #102147: vendor: bump runc to rc95
@kolyshkin kolyshkin mentioned this pull request May 21, 2021
Merged
@liggitt liggitt mentioned this pull request May 25, 2021
Closed
@github-actions github-actions bot mentioned this pull request May 26, 2021
Open
@odinuge odinuge mentioned this pull request Jun 7, 2021
Closed
@kolyshkin kolyshkin mentioned this pull request Jun 8, 2021
Closed
@odinuge odinuge mentioned this pull request Jul 7, 2021
Closed
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@aojea aojea Awaiting requested review from aojea

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@amwat amwat Awaiting requested review from amwat

+3 more reviewers

@odinuge odinuge odinuge left review comments

@ehashman ehashman ehashman left review comments

@harche harche harche approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@liggitt liggitt

@smarterclayton smarterclayton

@harche harche

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.22