Set cgroup values via libcontainer#98374
Conversation
|
/retest |
ae50fad to
c9f9d74
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test pull-kubernetes-node-crio-cgrpv2-e2e |
|
Still having some issues with cgroup v2 that need to be addressed. However, cc: /cc @rphillips @olegch |
|
@odinuge: GitHub didn't allow me to request PR reviews from the following users: olegch. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/test pull-kubernetes-node-crio-cgrpv2-e2e |
|
/retest |
|
/test pull-kubernetes-node-crio-cgrpv2-e2e |
|
/retest |
|
/test pull-kubernetes-node-crio-cgrpv2-e2e |
1 similar comment
|
/test pull-kubernetes-node-crio-cgrpv2-e2e |
94f610c to
e5787c8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: odinuge The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
e5787c8 to
86403ba
Compare
|
@odinuge: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
86403ba to
83a6fbb
Compare
This sets cgroup config via libcontainer to make sure we apply the correct values to the systemd slices and scopes.
83a6fbb to
f72158a
Compare
| if unified { | ||
| libcontainerCgroupConfig.Path = m.Name(cgroupConfig.Name) | ||
| } else { | ||
| libcontainerCgroupConfig.Paths = m.buildCgroupPaths(cgroupConfig.Name) |
There was a problem hiding this comment.
|
|
||
| // setSupportedSubsystemsV1 sets cgroup resource limits on cgroup v1 only on the supported | ||
| // subsystems. ie. cpu and memory. We don't use libcontainer's cgroup/fs/Set() | ||
| // method as it doesn't allow us to skip updates on the devices cgroup |
There was a problem hiding this comment.
This is now resolved by setting Resources.SkipDevices = true.
|
The last run for the job Putting it here explicitly because that job doesn't show up in the ci job list. |
|
Great news @harche ! |
|
/test pull-kubernetes-node-crio-e2e |
|
/priority critical-urgent |
|
I have included the commit from this PR to #102147, as it fixes the regression caused by rc94/rc95 update. |
|
I think this one can be closed in favor of #102147 (which includes a version of commit from this PR for runc rc94+). |
|
@odinuge: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close In favor of #102147 |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
WIP to run all e2e tests.
Currently we set cgroup values in
pkg/kubelet/cm/cgroup_manager_linux.gomanually per subsystem, howerever, when using the systemd driver, we should set them via opencontainers/runc/libcontainer to make sure we update the systemd slices and scopes.Will come back with more info when I have tested more.
Which issue(s) this PR fixes:
Fixes #88197
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: