Skip to content

[WIP][TEST] vendor: update runc and cadvisor#100631

Closed
giuseppe wants to merge 5 commits intokubernetes:masterfrom
giuseppe:test-e2e-cgroupv2
Closed

[WIP][TEST] vendor: update runc and cadvisor#100631
giuseppe wants to merge 5 commits intokubernetes:masterfrom
giuseppe:test-e2e-cgroupv2

Conversation

@giuseppe
Copy link
Copy Markdown
Member

@giuseppe giuseppe commented Mar 29, 2021

test:

opencontainers/runc#2873
google/cadvisor#2839

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

/hold

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 29, 2021

@giuseppe: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 29, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 29, 2021

@giuseppe: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 29, 2021
@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented Mar 29, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@k8s-ci-robot k8s-ci-robot requested review from a team, brendandburns and thockin March 29, 2021 13:36
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Mar 29, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: giuseppe
To complete the pull request process, please assign wojtek-t after the PR has been reviewed.
You can assign the PR to them by writing /assign @wojtek-t in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented Mar 29, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented Mar 29, 2021

@harche do we have the equivalent of pull-kubernetes-node-crio-cgrpv2-e2e on cgroup v1?

@giuseppe giuseppe force-pushed the test-e2e-cgroupv2 branch from 3e9b37b to 44b4189 Compare March 29, 2021 15:16
@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented Mar 29, 2021

/test pull-kubernetes-node-crio-e2e

@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented Mar 29, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@giuseppe giuseppe force-pushed the test-e2e-cgroupv2 branch from 44b4189 to 4730451 Compare March 29, 2021 21:19
@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented Mar 29, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@harche
Copy link
Copy Markdown
Contributor

harche commented Mar 30, 2021

@harche do we have the equivalent of pull-kubernetes-node-crio-cgrpv2-e2e on cgroup v1?

pull-kubernetes-node-crio-e2e

@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented Mar 30, 2021

/test pull-kubernetes-node-crio-e2e

@harche
Copy link
Copy Markdown
Contributor

harche commented Mar 30, 2021

pull-kubernetes-node-crio-e2e is also run as a pre-submit job.

@harche
Copy link
Copy Markdown
Contributor

harche commented Mar 30, 2021

It's hidden from the github UI, so you won't see pull-kubernetes-node-crio-e2e in the CI jobs in Github UI. You can use prow link to monitor the progress.

cc @giuseppe

@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented Mar 30, 2021

@harche thanks!

Now on cgroup v2 there are exactly the same failures as on cgroup v1, so these failures depend on something else

@harche
Copy link
Copy Markdown
Contributor

harche commented Mar 30, 2021 •
edited
Loading

That's cool but, other jobs triggered by other PRs aren't failing for pull-kubernetes-node-crio-e2e

This means changes in this PR are causing pull-kubernetes-node-crio-e2e to fail.

@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented May 3, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@giuseppe giuseppe force-pushed the test-e2e-cgroupv2 branch from c8156d2 to a2ecc5b Compare May 3, 2021 15:29
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 3, 2021
@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented May 3, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

giuseppe added 4 commits May 3, 2021 17:34
@giuseppe
test: adjust number of expected page faults
d6f2140 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
kubelet: reuse manager
57820a4 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
libcontainer: read root current pids from /proc
bf84a58 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
kubelet: adapt to the new libcontainer API
7d3921c 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the test-e2e-cgroupv2 branch from a2ecc5b to f494013 Compare May 3, 2021 15:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2021
@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented May 3, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2021
@giuseppe
vendor: update runc and cadvisor to latest
c02ff8d 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the test-e2e-cgroupv2 branch from f494013 to c02ff8d Compare May 3, 2021 16:01
@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented May 3, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 3, 2021 •
edited
Loading

@giuseppe: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim 039f7a82b7bc16e486c8b065dea9aaddd3542fb8 link /test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim
pull-kubernetes-dependencies c02ff8d link /test pull-kubernetes-dependencies

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented May 3, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@ehashman
Copy link
Copy Markdown
Member

ehashman commented May 11, 2021

@giuseppe runc94 is now available and bumped in cadvisor, do you wanna update this PR? Will these changes be necessary to take the update?

@kolyshkin kolyshkin mentioned this pull request May 11, 2021
Merged
@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented May 12, 2021

@giuseppe runc94 is now available and bumped in cadvisor, do you wanna update this PR? Will these changes be necessary to take the update?

I still don't see a new tag for cAdvisor though. There are some fixes in cAdvisor that are needed for e2e tests to pass on cgroup v2

@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented May 12, 2021

@bobbypage could we get a new release for cAdvisor?

@ehashman ehashman mentioned this pull request May 12, 2021
Closed
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 18, 2021
@kolyshkin kolyshkin mentioned this pull request May 19, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 21, 2021

@giuseppe: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@giuseppe giuseppe closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@thockin thockin Awaiting requested review from thockin

1 more reviewer

@kolyshkin kolyshkin kolyshkin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/dependency Issues or PRs related to dependency changes area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@giuseppe @k8s-ci-robot @harche @ehashman @kolyshkin @SergeyKanzhelev