Skip to content

Web terminal: fix warning when sourcing .bashrc#6848

Merged
kubermatic-bot merged 1 commit intokubermatic:mainfrom
SamuAlfageme:chmod_kubeconfig
Sep 18, 2024
Merged

Web terminal: fix warning when sourcing .bashrc#6848
kubermatic-bot merged 1 commit intokubermatic:mainfrom
SamuAlfageme:chmod_kubeconfig

Conversation

@SamuAlfageme
Copy link
Contributor

@SamuAlfageme SamuAlfageme commented Sep 16, 2024 •
edited by ahmedwaleedmalik
Loading

What this PR does / why we need it:

Since Helm 3.3.3, warning messages are displayed when the KUBECONFIG permissions are group/world readable. helm/helm#8779 writes them to stderr.

The warnings are displayed when opening the web terminal, as 'helm completion' execs when the .bashrc is sourced:

Screenshot 2024-09-16 at 22 30 01

... this confuses unexperienced users.

What type of PR is this?
/kind enhancement

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@SamuAlfageme
Web terminal: fix warning when sourcing .bashrc
2e1368d 
Since Helm 3.3.3, warning messages are displayed when the KUBECONFIG
permissions are group/world readable. helm/helm#8779
writes them to stderr.

The warnings are displayed when opening the web terminal, as 'helm completion'
execs when the .bashrc is sourced.

Signed-off-by: Samuel Alfageme Sainz <samuel@alfage.me>
@kubermatic-bot kubermatic-bot added kind/enhancement release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2024
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 16, 2024

Hi @SamuAlfageme. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2024
@SamuAlfageme
Copy link
Contributor Author

SamuAlfageme commented Sep 17, 2024

Should I also bump the web-terminal version for such a change?

dashboard/hack/images/web-terminal/release.sh

Line 23 in c041cac

VERSION=0.8.0

... or would you rather bundle it with more features?

@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Sep 18, 2024

... or would you rather bundle it with more features?

We can move ahead with this PR as is, let me re-evaluate if other dependencies need to be updated as well for web terminal in a follow-up PR. Thanks for the contribution 🎊

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 18, 2024

LGTM label has been added.

DetailsGit tree hash: 92490ca8921d0d23d806f859bae82a61a6a6a634

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Sep 18, 2024
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Sep 18, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Sep 18, 2024
@Waseem826
Copy link
Contributor

Waseem826 commented Sep 18, 2024

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2024
@kubermatic-bot kubermatic-bot merged commit 5d1ec10 into kubermatic:main Sep 18, 2024
@kubermatic-bot kubermatic-bot added this to the KKP 2.26 milestone Sep 18, 2024
@SamuAlfageme SamuAlfageme deleted the chmod_kubeconfig branch September 18, 2024 08:05
SamuAlfageme added a commit to SamuAlfageme/kkp-ui-api that referenced this pull request Sep 26, 2024
@SamuAlfageme
Revert "Web terminal: fix warning when sourcing .bashrc (kubermatic#6848
b53a7ca 
)"

This reverts commit 5d1ec10.

Signed-off-by: Samuel Alfageme Sainz <samuel@alfage.me>
@SamuAlfageme SamuAlfageme mentioned this pull request Sep 26, 2024
Merged
@kubermatic-bot kubermatic-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 26, 2024
@kubermatic-bot kubermatic-bot removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 26, 2024
kubermatic-bot pushed a commit that referenced this pull request Sep 26, 2024
@SamuAlfageme
Revert "Web terminal: fix warning when sourcing .bashrc (#6848)" (#6889)
9278816 
This reverts commit 5d1ec10.

Signed-off-by: Samuel Alfageme Sainz <samuel@alfage.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/enhancement lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

KKP 2.26

Development

Successfully merging this pull request may close these issues.

4 participants

@SamuAlfageme @kubermatic-bot @ahmedwaleedmalik @Waseem826