Skip to content

use warning function#8779

Merged
bacongobbler merged 1 commit intohelm:masterfrom
bacongobbler:use-warning
Sep 22, 2020
Merged

use warning function#8779
bacongobbler merged 1 commit intohelm:masterfrom
bacongobbler:use-warning

Conversation

@bacongobbler
Copy link
Member

This ensures warning messages are displayed on stderr rather than stdout.

relates to an issue discovered in #8776.

Signed-off-by: Matthew Fisher matt.fisher@microsoft.com

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2020
@bacongobbler bacongobbler added this to the 3.3.4 milestone Sep 21, 2020
@mattfarina mattfarina linked an issue Sep 21, 2020 that may be closed by this pull request
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2020
This ensures warning messages are displayed on stderr rather than stdout.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
@bacongobbler bacongobbler merged commit 03a1e8e into helm:master Sep 22, 2020
@bacongobbler bacongobbler deleted the use-warning branch September 22, 2020 18:13
@bacongobbler bacongobbler added the needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. label Sep 22, 2020
mattfarina added a commit to mattfarina/helm that referenced this pull request Sep 22, 2020
When helm#8779 was merged it introduced an issue with windows builds,
which we do not test for in PR CI. This change fixes that problem.

Signed-off-by: Matt Farina <matt@mattfarina.com>
@mattfarina mattfarina mentioned this pull request Sep 22, 2020
3 tasks
bacongobbler pushed a commit that referenced this pull request Sep 22, 2020
When #8779 was merged it introduced an issue with windows builds,
which we do not test for in PR CI. This change fixes that problem.

Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 036832e)
bacongobbler pushed a commit that referenced this pull request Sep 22, 2020
When #8779 was merged it introduced an issue with windows builds,
which we do not test for in PR CI. This change fixes that problem.

Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 036832e)
@bacongobbler bacongobbler added the picked Indicates that a PR has been cherry-picked into the next release candidate. label Sep 22, 2020
vladfr pushed a commit to vladfr/helm that referenced this pull request Sep 30, 2020
When helm#8779 was merged it introduced an issue with windows builds,
which we do not test for in PR CI. This change fixes that problem.

Signed-off-by: Matt Farina <matt@mattfarina.com>
zak905 pushed a commit to zak905/helm that referenced this pull request Jan 19, 2023
When helm#8779 was merged it introduced an issue with windows builds,
which we do not test for in PR CI. This change fixes that problem.

Signed-off-by: Matt Farina <matt@mattfarina.com>
SamuAlfageme added a commit to SamuAlfageme/kkp-ui-api that referenced this pull request Sep 16, 2024
Since Helm 3.3.3, warning messages are displayed when the KUBECONFIG
permissions are group/world readable. helm/helm#8779
writes them to stderr.

The warnings are displayed when opening the web terminal, as 'helm completion'
execs when the .bashrc is sourced.

Signed-off-by: Samuel Alfageme Sainz <samuel@alfage.me>
kubermatic-bot pushed a commit to kubermatic/dashboard that referenced this pull request Sep 18, 2024
Since Helm 3.3.3, warning messages are displayed when the KUBECONFIG
permissions are group/world readable. helm/helm#8779
writes them to stderr.

The warnings are displayed when opening the web terminal, as 'helm completion'
execs when the .bashrc is sourced.

Signed-off-by: Samuel Alfageme Sainz <samuel@alfage.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. picked Indicates that a PR has been cherry-picked into the next release candidate. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning after upgrading to 3.3.3

4 participants