Skip to content

Revert "Web terminal: fix warning when sourcing .bashrc (#6848)"#6889

Merged
kubermatic-bot merged 1 commit intokubermatic:mainfrom
SamuAlfageme:revert-6848-chmod-kubeconfig
Sep 26, 2024
Merged

Revert "Web terminal: fix warning when sourcing .bashrc (#6848)"#6889
kubermatic-bot merged 1 commit intokubermatic:mainfrom
SamuAlfageme:revert-6848-chmod-kubeconfig

Conversation

@SamuAlfageme
Copy link
Contributor

@SamuAlfageme SamuAlfageme commented Sep 26, 2024 •
edited by ahmedwaleedmalik
Loading

This reverts commit 5d1ec10.

What this PR does / why we need it:

After testing #6848, I realised the kubeconfig would be R/O and 0777 (kubernetes/kubernetes#125876) since it's mounted from a secret inside the web-terminal pod. This would result on an extra error on the web-terminal startup:

chmod: /etc/kubernetes/kubeconfig: Read-only file system

... rather than solving the warnings from Helm that #6848 intended to fix. This would require a more complex solution involving fsGroup + initContainers probably.

CC/ @ahmedwaleedmalik @Waseem826 as you took care of the previous PR. Sorry for the noise!

Which issue(s) this PR fixes: N/A

What type of PR is this?
/kind bug

Special notes for your reviewer:

NONE

Documentation:

NONE

@SamuAlfageme
Revert "Web terminal: fix warning when sourcing .bashrc (kubermatic#6848
b53a7ca 
)"

This reverts commit 5d1ec10.

Signed-off-by: Samuel Alfageme Sainz <samuel@alfage.me>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2024
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 26, 2024

Hi @SamuAlfageme. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone KKP 2.26

@kubermatic-bot kubermatic-bot added this to the KKP 2.26 milestone Sep 26, 2024
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 26, 2024

LGTM label has been added.

DetailsGit tree hash: b723264b4af122244026940e1eeaf22c8370002c

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 26, 2024
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Sep 26, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Sep 26, 2024
@kubermatic-bot kubermatic-bot merged commit 9278816 into kubermatic:main Sep 26, 2024
@SamuAlfageme SamuAlfageme deleted the revert-6848-chmod-kubeconfig branch September 26, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

KKP 2.26

Development

Successfully merging this pull request may close these issues.

4 participants

@SamuAlfageme @kubermatic-bot @ahmedwaleedmalik @Waseem826