Skip to content

[chore] Remove luajit-clean target#876

Merged
Frenzie merged 1 commit intokoreader:masterfrom
Frenzie:remove-luajit-clean-target
Mar 21, 2019
Merged

[chore] Remove luajit-clean target#876
Frenzie merged 1 commit intokoreader:masterfrom
Frenzie:remove-luajit-clean-target

Conversation

@Frenzie
Copy link
Copy Markdown
Member

@Frenzie Frenzie commented Mar 21, 2019

Deprecated by #567.

Originally added in #531 and #533.

@Frenzie
Copy link
Copy Markdown
Member Author

Frenzie commented Mar 21, 2019

@NiLuJe Unless there's a reason it should stay?

@NiLuJe
Copy link
Copy Markdown
Member

NiLuJe commented Mar 21, 2019

None that I can see OTOH ;).

@Frenzie Frenzie merged commit 7de036c into koreader:master Mar 21, 2019
@Frenzie Frenzie deleted the remove-luajit-clean-target branch March 21, 2019 13:34
Frenzie added a commit to Frenzie/koreader that referenced this pull request Mar 21, 2019
See koreader#4826 (comment)

Also some Makefile/CMake sanity/cleanup/style/refactoring.

Includes:

* [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870
* [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872
* [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873
* [fix] Return fail status for SDL koreader/koreader-base#874
* [chore] Makefile: declare all phonies koreader/koreader-base#875
* [chore] Remove luajit-clean target koreader/koreader-base#876
* [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Frenzie added a commit to koreader/koreader that referenced this pull request Mar 21, 2019
See #4826 (comment)

Also some Makefile/CMake sanity/cleanup/style/refactoring.

Includes:

* [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870
* [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872
* [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873
* [fix] Return fail status for SDL koreader/koreader-base#874
* [chore] Makefile: declare all phonies koreader/koreader-base#875
* [chore] Remove luajit-clean target koreader/koreader-base#876
* [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
See koreader#4826 (comment)

Also some Makefile/CMake sanity/cleanup/style/refactoring.

Includes:

* [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870
* [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872
* [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873
* [fix] Return fail status for SDL koreader/koreader-base#874
* [chore] Makefile: declare all phonies koreader/koreader-base#875
* [chore] Remove luajit-clean target koreader/koreader-base#876
* [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants