[fix] Add util.ffiLoadCandidates to try multiple SDL2 library names#873
Merged
Frenzie merged 1 commit intokoreader:masterfrom Mar 21, 2019
Merged
[fix] Add util.ffiLoadCandidates to try multiple SDL2 library names#873Frenzie merged 1 commit intokoreader:masterfrom
Frenzie merged 1 commit intokoreader:masterfrom
Conversation
Fixes <koreader/koreader#4826 (comment)>. A bit like the idea penned down [here](koreader/koreader#3108 (comment)).
cc3abe7 to
e875c96
Compare
NiLuJe
approved these changes
Mar 20, 2019
Member
NiLuJe
left a comment
There was a problem hiding this comment.
Binary distro be stupid.
LGTM! ;).
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Mar 21, 2019
Fixes minor typo with embarrassing consequences from koreader#873 The file I committed accidentally wasn't 100 % the same as the one I tested. That would've blown up in a pretty embarrassing way.
Frenzie
added a commit
that referenced
this pull request
Mar 21, 2019
Fixes minor typo with embarrassing consequences from #873 The file I committed accidentally wasn't 100 % the same as the one I tested. That would've blown up in a pretty embarrassing way.
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Mar 21, 2019
See koreader#4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Mar 21, 2019
See #4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Contributor
|
Unfortunately, even with this fix, I ran into the missing libSDL.so issue. I'm running a Void Linux chroot, and the problem is that it ships libraries with version strings in the filename: e.g. |
Member
Author
|
No symlinks of any sort? On my Debian On older versions it's the same, except on Ubuntu 16.04, for example, the actual library is
|
Contributor
|
Looks like I've just got |
Member
Author
|
Alright, so then we can add |
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Aug 3, 2019
As proposed but forgotten to add in <koreader#873 (comment)>. Fixes <koreader/koreader#5122>.
Frenzie
added a commit
that referenced
this pull request
Aug 3, 2019
As proposed but forgotten to add in <#873 (comment)>. Fixes <koreader/koreader#5122>.
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
See koreader#4826 (comment) Also some Makefile/CMake sanity/cleanup/style/refactoring. Includes: * [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870 * [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872 * [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873 * [fix] Return fail status for SDL koreader/koreader-base#874 * [chore] Makefile: declare all phonies koreader/koreader-base#875 * [chore] Remove luajit-clean target koreader/koreader-base#876 * [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes koreader/koreader#4826 (comment).
A bit like the idea penned down here.