Skip to content

[build] Move Android ZLIB_LDFLAGS to thirdparty/zlib#870

Merged
Frenzie merged 5 commits intokoreader:masterfrom
Frenzie:zlib-ldflags-android
Mar 19, 2019
Merged

[build] Move Android ZLIB_LDFLAGS to thirdparty/zlib#870
Frenzie merged 5 commits intokoreader:masterfrom
Frenzie:zlib-ldflags-android

Conversation

@Frenzie
Copy link
Copy Markdown
Member

@Frenzie Frenzie commented Mar 19, 2019

This seems clearer to me.

@Frenzie Frenzie requested a review from NiLuJe March 19, 2019 10:12
Copy link
Copy Markdown
Member

@NiLuJe NiLuJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM!

@Frenzie Frenzie merged commit 2245680 into koreader:master Mar 19, 2019
@Frenzie Frenzie deleted the zlib-ldflags-android branch March 19, 2019 13:38
Frenzie added a commit to Frenzie/koreader that referenced this pull request Mar 21, 2019
See koreader#4826 (comment)

Also some Makefile/CMake sanity/cleanup/style/refactoring.

Includes:

* [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870
* [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872
* [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873
* [fix] Return fail status for SDL koreader/koreader-base#874
* [chore] Makefile: declare all phonies koreader/koreader-base#875
* [chore] Remove luajit-clean target koreader/koreader-base#876
* [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Frenzie added a commit to koreader/koreader that referenced this pull request Mar 21, 2019
See #4826 (comment)

Also some Makefile/CMake sanity/cleanup/style/refactoring.

Includes:

* [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870
* [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872
* [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873
* [fix] Return fail status for SDL koreader/koreader-base#874
* [chore] Makefile: declare all phonies koreader/koreader-base#875
* [chore] Remove luajit-clean target koreader/koreader-base#876
* [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
See koreader#4826 (comment)

Also some Makefile/CMake sanity/cleanup/style/refactoring.

Includes:

* [build] Move Android ZLIB_LDFLAGS to thirdparty/zlib koreader/koreader-base#870
* [chore] Update CMake to modern style with lowercase commands koreader/koreader-base#872
* [fix] Add util.ffiLoadCandidates to try multiple SDL2 library names koreader/koreader-base#873
* [fix] Return fail status for SDL koreader/koreader-base#874
* [chore] Makefile: declare all phonies koreader/koreader-base#875
* [chore] Remove luajit-clean target koreader/koreader-base#876
* [chore] CMake kpvcrlib convert remaining tabs to four spaces koreader/koreader-base#877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants