luajit: patch out library from pkg-config entry when not used#1930
Merged
Frenzie merged 1 commit intoSep 8, 2024
Conversation
To prevent Lua modules from linking with it.
Member
Author
|
In preparation for using pkg-config to handle LuaJIT's compilation flags in some external projects ( |
Member
|
Wasn't there a thing where on Android (and possibly macOS?), Lua/C modules needed to be explicitly linked to the luajit lib for... reasons? |
Member
Author
|
Yes, which is why it's only patched out when we don't use the luajit library. |
Member
|
Oh, duh'. Long day, sorry ;). |
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Sep 10, 2024
- koreader/koreader-base#1921 - koreader/koreader-base#1922 - koreader/koreader-base#1923 - koreader/koreader-base#1924 - koreader/koreader-base#1926 - koreader/koreader-base#1927 - koreader/koreader-base#1928 - koreader/koreader-base#1930 - koreader/koreader-base#1931 Close koreader#12462, koreader#12473.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
- koreader/koreader-base#1921 - koreader/koreader-base#1922 - koreader/koreader-base#1923 - koreader/koreader-base#1924 - koreader/koreader-base#1926 - koreader/koreader-base#1927 - koreader/koreader-base#1928 - koreader/koreader-base#1930 - koreader/koreader-base#1931 Close koreader#12462, koreader#12473.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent Lua modules from linking with it.
This change is