Lua blitter: Fix the mul method for grayscale Color data types#1922
Merged
Conversation
We want to access the actual luminance value instead of the struct pointer ;o). Fix koreader/koreader#12473
Member
Author
|
At a quick re-re-review, I don't appear to have bungled this up anywhere else ;). Not quite sure how I missed it in the first place, as I did test the Lua blitter back in January, on both color & grayscale BBs. Must have implemented the MUL stuff later or something... -_-". |
Frenzie
approved these changes
Sep 7, 2024
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Sep 10, 2024
- koreader/koreader-base#1921 - koreader/koreader-base#1922 - koreader/koreader-base#1923 - koreader/koreader-base#1924 - koreader/koreader-base#1926 - koreader/koreader-base#1927 - koreader/koreader-base#1928 - koreader/koreader-base#1930 - koreader/koreader-base#1931 Close koreader#12462, koreader#12473.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
- koreader/koreader-base#1921 - koreader/koreader-base#1922 - koreader/koreader-base#1923 - koreader/koreader-base#1924 - koreader/koreader-base#1926 - koreader/koreader-base#1927 - koreader/koreader-base#1928 - koreader/koreader-base#1930 - koreader/koreader-base#1931 Close koreader#12462, koreader#12473.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to access the actual luminance value instead of the struct pointer ;o).
Fix koreader/koreader#12473
This change is