ffi/mupdf: fix metadata strings#1921
Merged
Frenzie merged 1 commit intoSep 5, 2024
Merged
Conversation
Don't create Lua strings with an embedded null terminator.
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Sep 10, 2024
- koreader/koreader-base#1921 - koreader/koreader-base#1922 - koreader/koreader-base#1923 - koreader/koreader-base#1924 - koreader/koreader-base#1926 - koreader/koreader-base#1927 - koreader/koreader-base#1928 - koreader/koreader-base#1930 - koreader/koreader-base#1931 Close koreader#12462, koreader#12473.
This was referenced Sep 18, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Sep 23, 2024
(1) Followup to koreader/koreader-base#1921, #12503: when getting a pdf book id in the stats db, check for old records with null terminated authors and title. Discussed in #11318. There are some other reasons for disappearing old stats for pdf (md5 changes when converting/writing to pdf or something else), hence not closing the issue. (2) Add Dispatcher action for toggling statistics. Closes #11422.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
- koreader/koreader-base#1921 - koreader/koreader-base#1922 - koreader/koreader-base#1923 - koreader/koreader-base#1924 - koreader/koreader-base#1926 - koreader/koreader-base#1927 - koreader/koreader-base#1928 - koreader/koreader-base#1930 - koreader/koreader-base#1931 Close koreader#12462, koreader#12473.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…2547) (1) Followup to koreader/koreader-base#1921, koreader#12503: when getting a pdf book id in the stats db, check for old records with null terminated authors and title. Discussed in koreader#11318. There are some other reasons for disappearing old stats for pdf (md5 changes when converting/writing to pdf or something else), hence not closing the issue. (2) Add Dispatcher action for toggling statistics. Closes koreader#11422.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't create Lua strings with an embedded null terminator.
Cf. koreader/koreader#12468.
This change is