Cleanup various varargs shenanigans#9624
Merged
Merged
Conversation
Use select instead
Which is always nioce, since function arguments are always evaluated.
NiLuJe
commented
Oct 12, 2022
NiLuJe
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
This was referenced Oct 24, 2022
Frenzie
pushed a commit
that referenced
this pull request
Oct 25, 2022
argc was eliminated in #9624 Thanks to @hius07 #9680 (comment) Plus a minor change in the scheduling test, so that the _task_queue is not filled only from one end.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Apr 23, 2023
c.f., koreader/koreader-base#1603 for more details. Re: koreader#9624
NiLuJe
added a commit
that referenced
this pull request
Apr 23, 2023
c.f., koreader/koreader-base#1603 for more details. Re: #9624
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
* Iterate over varargs directly via select if possible * Use table.pack otherwise (koreader/koreader-base#1535). * This allows us to simplify a few Logger calls, as logger now handles nil values.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
argc was eliminated in koreader#9624 Thanks to @hius07 koreader#9680 (comment) Plus a minor change in the scheduling test, so that the _task_queue is not filled only from one end.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
c.f., koreader/koreader-base#1603 for more details. Re: koreader#9624
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is