Deal with table.pack corner-cases properly#1603
Merged
Merged
Conversation
Turns out we can't rely on the len operator in all cases, as it may get confused depending on where the `nil`s are, so always use the `n` field instead, as that *is* reliable. Re: koreader#1535
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Apr 23, 2023
c.f., koreader/koreader-base#1603 for more details. Re: 9624
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Apr 23, 2023
c.f., koreader/koreader-base#1603 for more details. Re: koreader#9624
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Apr 23, 2023
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Apr 23, 2023
c.f., koreader/koreader-base#1603 for more details. Re: #9624
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
c.f., koreader/koreader-base#1603 for more details. Re: koreader#9624
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we can't rely on the len operator in all cases, as it may get confused depending on where the
nils are, so always use thenfield instead, as that is reliable.Re: #1535
This change is