Conversation
Contributor
|
i think you meant @hius07 for #9680 (comment) |
NiLuJe
reviewed
Oct 25, 2022
| table.insert( | ||
| UIManager._task_queue, | ||
| { time = now + i, action = noop, argc = 0, args = {} } | ||
| { time = now + i, action = noop, args = {} } |
Member
There was a problem hiding this comment.
Harmless here because the table is empty, but, FWIW, if you do need to set args, the arg count is folded in the table, and it needs to happen at table construction, and in this order:
{n = 4, 1, nil, nil, 4}
(Leaving this here for future archeologists, c.f., koreader/koreader-base#1535 (comment) ;)).
NiLuJe
approved these changes
Oct 25, 2022
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
argc was eliminated in koreader#9624 Thanks to @hius07 koreader#9680 (comment) Plus a minor change in the scheduling test, so that the _task_queue is not filled only from one end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
argc was eliminated in #9624
Thanks to @hasezoey (#9680 (comment))
Plus a minor change in the scheduling test, so that the _task_queue is not filled only from one end.
This change is