[chore] Extract Cyrillic/Russian keyboard#5610
Conversation
Follow-up to koreader#5583.
|
@yparitcher Quick sanity check before I continue? |
|
Cross-ref to #2032 for specifics on the Cyrillic/Russian keyboard. |
looks good so far. btw if you only need 4 layers for a specific language you can, see hebrew for example. |
|
I haven't looked at them all yet. Portuguese seems to be using all layers fully so it's a bit problematic, but I think it should be covered by my updated English keyboard with swipes/popups. |
|
either the english one, or if you want to have a Portuguese specific keyboard, you can move the letters with diacritics from other layers to a popup. |
|
I don't know if I want anything at this point. It's not like I've researched stuff like https://en.wikipedia.org/wiki/Portuguese_keyboard_layout yet, nor our own history. ;-) Iirc @robert00s wrote it. |
poire-z
left a comment
There was a problem hiding this comment.
Looks allright: nothing unbalanced jumps at me :)
| { "サ", "さ", "@", "2", }, | ||
| { "タ", "た", "#", "3", }, | ||
| { "ナ", "な", "$", "4", }, | ||
| { "ハ", "は", "%", "5", }, |
There was a problem hiding this comment.
Any idea why that one (2nd char among the 4) is highlighted by github diff?
(And actually always one at the same place in the 3 following sections.)
There was a problem hiding this comment.
I double checked the characters and they seem to be exactly the same, so I can only assume it's an obscure GH bug.
There was a problem hiding this comment.
@poire-z I now understand why it is. It relates to why I accidentally deleted a few layers in the Japanese layout. The tenth layout is exactly the same as the second, except on this specific line where it's ぱ instead of は. But GH (intelligently?) regards this as a change rather than as deleting the third to tenth layout. It probably has something to do with the number of spaces.
|
I'll merge it so that it makes it into the next nightly together with the keyboard layout selection. I tested all the keyboards and I didn't do anything new/weird, so it should be good. ^_^ |
|
The korean keyboard got a large globe key, which make the popup large too: Also, for usability, it would be nice if all the globe keys were at the same position when switching layouts (the hebrew keyboard makes it move position) - possibly by making the space bar larger so the bottom row always take the full width: |
|
You know, I was going to suggest just making the buttons larger to that PS Japanese doesn't have Sym. (But it does have roughly the same location.) |
|
Not clear in my post, but I wanted to say I don't like it larger :) I like it at the smaller size it has in the english keyboard. |
Follow-up to koreader#5583. * Add separate Cyrillic/Russian keyboard * And remove that from English * Update French keyboard (is easy) * Remove yahzhert, that was just a double of QWERTY * Update Spanish keyboard * Reduce Japanese to 4 layers and add globe * Reduce Korean to 4 layers * Reduce Greek to 8 layers
Changes in this commit: - Fix arrays to large (10 elements instead of 8) copied from the old keyboard system. Issue introduced in koreader#5610 - Add ё popup. - Change shift key as per koreader#5659 (for both ro and ru keyboards) - Translate Russian space and symbol keys. - Rename Sym key to 123
Follow-up to #5583.
This change is