Skip to content

russian keyboard layout improvement from mergen3107#2032

Merged
chrox merged 2 commits intomasterfrom
keyboard
Jun 1, 2016
Merged

russian keyboard layout improvement from mergen3107#2032
chrox merged 2 commits intomasterfrom
keyboard

Conversation

@houqp
Copy link
Copy Markdown
Member

@houqp houqp commented May 17, 2016 •
edited
Loading

This is the new keyboard layout proposed by mergen3107 in #2029. Let's discuss it here.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented May 17, 2016

I don't know anything about Cyrillic layouts. The current layout appears to be the "YaZHert" (яЖерт) variety. See http://web.archive.org/web/20160310035217/http://winrus.com/print_e.htm

@mergen3107
Copy link
Copy Markdown
Contributor

mergen3107 commented May 17, 2016 •
edited
Loading

Russian layout
So this is the most used Russian layout - I intentionally found a picture with both English and Russian layouts together. You can clearly notice that letters (х,ъ), (ж,э), (б, ю) on the right and ё to left from number 1 in the corner are outside English-substitutes (by substitutes I mean the keys, where I put Russian letters).

So what I did:

  1. For keys from 26-letter matrix I just copied Russian layout as it is;
    reader_2016-may-17_174955

  2. For those 7 outside letters I put them into Sym on the right, so that they could be found very easily and quickly;
    reader_2016-may-17_175003

  3. Numeric keypad in Sym I changed from linear to block type for the sake of step (2)

  4. The rest of space was filled by 9 Kazakh letters (they magically fitted exactly all left space between numeric block and Russian letters.

  5. For shifted symbols in Sym I used some characters on places of numbers and shifted letters.
    reader_2016-may-17_175021

Hope you like it!
Thank you!

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented May 17, 2016

It definitely seems more sensible to default to the most common layout.

@houqp
Copy link
Copy Markdown
Member Author

houqp commented May 27, 2016

Alright, I factor out the keyboard layout into a loadable file so it's easier to turn it into a configurable option in the future.

I only suggestion so far is to make the number to symbol mapping in shift mode more consistent with what's on the physical keyboard. I.e. 1 -> !, 2 -> @, ..., etc. Any objection?

@mergen3107 , how did you come up with the current symbol mapping layout?

@mergen3107
Copy link
Copy Markdown
Contributor

mergen3107 commented May 27, 2016

@houqp
good suggestion! Actually I was trying to fit the most used symbols randomly
I'll think on that on the weekend

@houqp
move keyboard layout into data modules
6a1fa7f 
also changed keyboard mode for number to 4
@houqp
Copy link
Copy Markdown
Member Author

houqp commented May 29, 2016

OK, I have changed the layout so that it matches with the number to symbol mapping on standard US keyboards. Please review :)

@mergen3107
Copy link
Copy Markdown
Contributor

mergen3107 commented May 29, 2016

@houqp
I'll check this out soon :)

@chrox chrox merged commit ffca77a into master Jun 1, 2016
@mergen3107
Copy link
Copy Markdown
Contributor

mergen3107 commented Jun 20, 2016

@houqp
I installed the latest 431 nightly with Virtual Keyboard layouts moved to data/modules, but I can't find your iterations. Keyboard symbols underneath the numbers look like the same as I left them before.
Is there any file I missed from you?

@houqp
Copy link
Copy Markdown
Member Author

houqp commented Jun 21, 2016

The sym layout had a overhaul based on yours, can you paste your original layout here to verify?

@mergen3107
Copy link
Copy Markdown
Contributor

mergen3107 commented Jun 21, 2016

Here it is!
virtualkeyboard.zip
Compared with 431 nightly, mine is the same.

@houqp
Copy link
Copy Markdown
Member Author

houqp commented Jun 22, 2016 •
edited
Loading

My change is different from yours, see:

  {  --  1           2       3       4       5       6       7       8       9       10      11      12
         { "Q",        "q",    "!",    "1",    "Я",    "я",    "1",    "!",    "Ä",    "ä",    "1",    "ª", },
         { "W",        "w",    "?",    "2",    "Ж",    "ж",    "2",    "?",    "Ö",    "ö",    "2",    "º", },
         { "E",        "e",    "|",    "3",    "Е",    "е",    "3",    "«",    "Ü",    "ü",    "3",    "¡", },
         { "R",        "r",    "#",    "4",    "Р",    "р",    "4",    "»",    "ß",    "ß",    "4",    "¿", },
         { "T",        "t",    "@",    "5",    "Т",    "т",    "5",    ":",    "À",    "à",    "5",    "¼", },
         { "Y",        "y",    "‰",    "6",    "Ы",    "ы",    "6",    ";",    "Â",    "â",    "6",    "½", },
         { "U",        "u",    "'",    "7",    "У",    "у",    "7",    "~",    "Æ",    "æ",    "7",    "¾", },
         { "I",        "i",    "`",    "8",    "И",    "и",    "8",    "(",    "Ç",    "ç",    "8",    "©", },
         { "O",        "o",    ":",    "9",    "О",    "о",    "9",    ")",    "È",    "è",    "9",    "®", },
         { "P",        "p",    ";",    "0",    "П",    "п",    "0",    "=",    "É",    "é",    "0",    "™", },
     }

vs yours:

        {  --  1           2       3       4       5       6       7       8       9       10      11      12
            { "Q",        "q",    "?",    "!",    "Й",    "й",    "?",    "!",    "Ä",    "ä",    "1",    "ª", },
            { "W",        "w",    "|",    "1",    "Ц",    "ц",    "(",    "1",    "Ö",    "ö",    "2",    "º", },
            { "E",        "e",    "#",    "2",    "У",    "у",    ")",    "2",    "Ü",    "ü",    "3",    "¡", },
            { "R",        "r",    "_",    "3",    "К",    "к",    "~",    "3",    "ß",    "ß",    "4",    "¿", },
            { "T",        "t",    "=",    "@",    "Е",    "е",    "Ә",    "ә",    "À",    "à",    "5",    "¼", },
            { "Y",        "y",    "\\",    "‰",    "Н",    "н",    "І",    "і",    "Â",    "â",    "6",    "½", },
            { "U",        "u",    "$",    "'",    "Г",    "г",    "Ң",    "ң",    "Æ",    "æ",    "7",    "¾", },
            { "I",        "i",    "€",    "`",    "Ш",    "ш",    "Ғ",    "ғ",    "Ç",    "ç",    "8",    "©", },
            { "O",        "o",    "£",    ":",    "Щ",    "щ",    "Х",    "х",    "È",    "è",    "9",    "®", },
            { "P",        "p",    "…",    ";",    "З",    "з",    "Ъ",    "ъ",    "É",    "é",    "0",    "™", },
        },

@chrox chrox deleted the keyboard branch July 2, 2016 03:14
@Frenzie Frenzie mentioned this pull request Nov 18, 2019
Merged
@Frenzie Frenzie added the UX label Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@houqp @Frenzie @mergen3107 @chrox