Skip to content

KOReader - Better Russian Keyboard Layout (with Kazakh)#2029

Closed
mergen3107 wants to merge 18 commits intohouqp-masterfrom
master
Closed

KOReader - Better Russian Keyboard Layout (with Kazakh)#2029
mergen3107 wants to merge 18 commits intohouqp-masterfrom
master

Conversation

@mergen3107
Copy link
Copy Markdown
Contributor

@mergen3107 mergen3107 commented May 16, 2016

Dear KOReader Dev Community!
Here is a suggestion coming from this thread.

The file virtualkeyboard.lua is atteched in a ZIP archive:
koreader-KZ-Keyboard.zip

Thank you!


This change is Reviewable

Frenzie and others added 14 commits May 3, 2016 08:40
test flush config before suspend
Multi-line toggle switch & add instruction to resolve sdcv build error.
Bump k2pdfopt to v2.34, tesseract-ocr to 3.04 and leptonica to v1.72
rename 'Highlight' to 'Highlight options' in menu
I wouldn't go so far as to say "support", though, since I don't have the
device, and the touch protocol might be wrong ;).

re #2005
When using KFMon, make the reboot on exit user-configurable.
The user can now choose to try to restart Nickel directly, like with
fmon.
For now, we still do a full reboot by default.
@NiLuJe
Copy link
Copy Markdown
Member

NiLuJe commented May 16, 2016

I think you mixed up something in the source -> target of your PR, didn't you? ;).

@mergen3107
Copy link
Copy Markdown
Contributor Author

@NiLuJe
yeah, I still don't get how to properly add a new Pull Request. It asks to choose one of the comparisons, so I got totally confused.
If there something I missed to read carefully?

@NiLuJe
Copy link
Copy Markdown
Member

NiLuJe commented May 16, 2016

@mergen3107: GH's Help has some human-readable intro to git & GH.

If you want to delve into a specific issue, the go to place is the Git Book ;).

Basically, you want to make sure your fork is up to date with the "master" repo (usually you setup an "upstream" remote to point to it), so the PR will only pickup your commit. You achieve that usually with a merge if there's no conflict, or a rebase if there is.

@mergen3107
Copy link
Copy Markdown
Contributor Author

Thank you! I'll read that on my spare time :)

@houqp houqp closed this May 17, 2016
@houqp
Copy link
Copy Markdown
Member

houqp commented May 17, 2016

I will take sometime to manually apply the patch in the zip file tonight. Thanks @mergen3107 for the work.

@mergen3107
Copy link
Copy Markdown
Contributor Author

Thank you too for your enthusiastic hard work! I am happy to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants