Skip to content

[UX] Simple symbol keyboard layer paging#5659

Merged
Frenzie merged 1 commit intokoreader:masterfrom
Frenzie:sym-layer
Dec 13, 2019
Merged

[UX] Simple symbol keyboard layer paging#5659
Frenzie merged 1 commit intokoreader:masterfrom
Frenzie:sym-layer

Conversation

@Frenzie
Copy link
Copy Markdown
Member

@Frenzie Frenzie commented Nov 30, 2019

Here's a quick concept for consideration. Use 1/2 and 2/2 instead of Shift.

Screenshot_2019-11-30_16-01-28
Screenshot_2019-11-30_16-01-35


This change is Reviewable

Use 1/2 and 2/2 instead of Shift.
@Frenzie Frenzie added this to the 2019.12 milestone Nov 30, 2019
@SilverGreen93
Copy link
Copy Markdown
Contributor

SilverGreen93 commented Dec 1, 2019

I also renamed the Sym key to 123 in my romanian keyboard, and changed that to an alt key when you are in the second character page (see #5660)
1/2, 2/2 are a welcome additional change.

@poire-z
Copy link
Copy Markdown
Contributor

poire-z commented Dec 1, 2019

Well, before the highlighting of the Shift key, I would have liked it :)
But with the highlighting, it feels a bit less needed - and having 2/2 highlighted (1/2 is not) feels strange/duplicated...
Also, I feel the Shift symbol less ambiguous. I could expect hitting 1/2 would output 1/2 :) Because the ... just above the 2/2 will output ..., while I could as well expect it will move me to the ...next... layer :)

Anyway, just a thought. Go ahead if you prefer it that way.

@NiLuJe
Copy link
Copy Markdown
Member

NiLuJe commented Dec 2, 2019

I'd also tend to prefer a symbol over this, too.

I'm okay with Shift, as it's fairly universal, but we also have access to Apple's Command & Alt/Option glyph which might make more sense than shift in this context (the alt one, especially).

At least for people familiar with Apple layouts ;p.

@SilverGreen93
Copy link
Copy Markdown
Contributor

The shift symbol here I can say it seems a bit ambiguous. On the main letter keyboard it makes sense, but on the symbols keyboard it should indicate something that "there are more symbols here". I would go with anything else BUT the shift symbol.

@NiLuJe
Copy link
Copy Markdown
Member

NiLuJe commented Dec 2, 2019

FWIW, I have no strong opinion on that subject. I'd vaguely prefer a symbol (because I also find that it's enough since the HL tweak), but that's it ;).

@Frenzie
Copy link
Copy Markdown
Member Author

Frenzie commented Dec 2, 2019

I think any symbol would be significantly less clear than a simple 1/2 and 2/2. Shift would at least be consistent and therefore better than anything trying to be too clever.

Frenzie pushed a commit that referenced this pull request Dec 3, 2019
Changes in this commit:
- Fix arrays to large (10 elements instead of 8) copied from the old keyboard system.  Issue introduced in #5610 
- Add ё popup.
- Change shift key as per #5659 (for both ro and ru keyboards)
- Translate Russian space and symbol keys.
- Rename Sym key to 123
@Frenzie
Copy link
Copy Markdown
Member Author

Frenzie commented Dec 13, 2019

I'm still in favor of this proposal. Has it grown on you guys by any chance @poire-z @NiLuJe? ;-)

@poire-z
Copy link
Copy Markdown
Contributor

poire-z commented Dec 13, 2019

Well, I didn't give it a chance to grow on me :) but as I get now that it applies only on the symbol/number layers, it's less drastic that I initially thought. So go ahead.

@Frenzie Frenzie added the UX label Dec 13, 2019
@Frenzie Frenzie merged commit 7d231ac into koreader:master Dec 13, 2019
@Frenzie Frenzie deleted the sym-layer branch December 13, 2019 15:20
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Changes in this commit:
- Fix arrays to large (10 elements instead of 8) copied from the old keyboard system.  Issue introduced in koreader#5610 
- Add ё popup.
- Change shift key as per koreader#5659 (for both ro and ru keyboards)
- Translate Russian space and symbol keys.
- Rename Sym key to 123
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Use 1/2 and 2/2 instead of Shift on the symbol layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants