Skip to content

File browser: show Folder Menu on long-press on Home icon#10298

Merged
hius07 merged 3 commits into
koreader:masterfrom
hius07:folder-menu-on-tap
Apr 5, 2023
Merged

File browser: show Folder Menu on long-press on Home icon#10298
hius07 merged 3 commits into
koreader:masterfrom
hius07:folder-menu-on-tap

Conversation

@hius07

@hius07 hius07 commented Apr 4, 2023 •
edited by Frenzie
Loading

Copy link
Copy Markdown
Member

Also fixes unreadable folder name in root (#10275 (comment)).

This change is Reviewable

@Frenzie Frenzie added this to the 2023.04 milestone Apr 4, 2023
@hius07 hius07 merged commit 483a005 into koreader:master Apr 5, 2023
@hius07 hius07 deleted the folder-menu-on-tap branch April 5, 2023 05:24
@mergen3107

mergen3107 commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Thank you!

Tested this quickly:

  1. Home button works fine, no crashes above Home with long taps too.
  2. storage is now spelt correctly
  3. The 0 folder inside /storage/emulated/ is still not visible. Is this a hard limitation? Can it fixed? It’s not a big deal, I can go to Home from there anyway

@hius07

hius07 commented Apr 5, 2023

Copy link
Copy Markdown
Member Author

3. The 0 folder inside /storage/emulated/ is still not visible.

What do you mean? I have on my phone:

1

2

3

4

@mergen3107

mergen3107 commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Interesting! I have everything the same except for screenshot 3: there is no folder or file there.

Should I log it?

@NiLuJe

NiLuJe commented Apr 5, 2023

Copy link
Copy Markdown
Member

What sorting method are you using?

(I could kinda see natural sorting shenanigans doing weird things with a single 0, for instance).

@mergen3107

mergen3107 commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Huh, this is so strange. Today I see the 0 folder there for the first time!

I only did KOReader restart once, no crashes, since my last report here 🧐

@mergen3107

mergen3107 commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Sorting by name or by name (natural sorting) has no effect, folder is still there

@poire-z

poire-z commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

From what I remember, we only know about 0 when we see it in the path.
So, you should see it when navigating from under it towards the root.
If you come in from the root / and metting /storage/emulated/ - and KOReader session's file browser has never navigated the other direction, you should not see 0.
This may explain why sometimes you see it sometimes not.

@mergen3107

mergen3107 commented Apr 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks @poire-z !
Seems like this is (again) how you described it. Here is what I found:
0) Restarted KOReader via its Exit and launching again.

  1. KOReader is set to open previous book. Home is inside 0, for sure, so it starts wherever the book is, when I go to FM.
  2. Use long-tap, go to /, see absolutely nothing, except ... Go back to home via tap.
  3. Go to /storage via long tap, see emulated, go there: nothing again. Go back home.
  4. Now, use physical back button, which is set to go to parent folder, quit from /storage/emulated/0/Books/ to /storage/emulated/ : see nothing again.
  5. HOWEVER, if I go back with the .. on top of the files when I am in /storage/emulated/0, I can see two lines now! One is “This folder content is not visible etc”, another is 0 folder.

Now anytime I go there by any means, the folder is there until I restart KOReader again.

I am glad I am NOT going crazy (yet) :D

@mergen3107

mergen3107 commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

Here is log I took after doing these steps again:
crash_0folder.log

TranHHoang added a commit to TranHHoang/koreader that referenced this pull request May 26, 2023
@TranHHoang
Merge tag 'v2023.04' into custom
c8c4a28 
KOReader 2023.04 "Solar Panel"

![koreader-2023-04-fs8](https://user-images.githubusercontent.com/202757/234975122-d7739c71-74aa-4cb0-a086-72a4bba70f52.png)

It's been another busy month squashing many bugs. Our Mac users will be happy to hear that I told macOS we've supported HiDPI since long before anyone came up with such terminology (koreader#10341), and that the program can now natively build on M1 devices (koreader#10291).

Solar panel credit: <https://openclipart.org/detail/294030/solar-energy> by gnokii

We'd like to thank all contributors for their efforts. Some highlights since the previous release include:

* Readerzooming: fix use of default settings (koreader#10205) @hius07
* ButtonDialog/ButtonDialogTitle: consistent 'width' handling (koreader#10230) @poire-z
* MovableContainer: add support for anchoring initial position (koreader#10230) @poire-z
* Book map, Page browser: add top left menu (koreader#10230) @poire-z
* Book style tweak: add button with CSS suggestions (koreader#10230) @poire-z
* crengine: fix parsing of multibytes encodings (koreader#10230) @poire-z
* readerstyletweak: update profiles on unregistering in dispatcher (koreader#10247) @hius07
* Filesearcher: add search in book metadata (koreader#10198) @hius07
* Fix: Updated legacy directory, which crashed the program (koreader#10260) @Mochitto
* ReaderLink: allow a forward location stack (koreader#10228) @yparitcher
* BookInfo: add page information (koreader#10255) @hius07
* Center pdf manual zoom mode (koreader#10246) @nairyosangha
* File browser: add Folder Menu (koreader#10275) @hius07
* Calendar view: add options to change start time of days (koreader#10254) @weijiuqiao
* filechooser: fix crash on "unreadable content" (koreader#10283) @hius07
* Sync book statistics: add to dispatcher (koreader#10285) @ptrm
* [plugin] Exporter: use util.getSafeFilename() to remove illegal characters from output filename (koreader#10282) @Mochitto
* readerbookmark: fix writing pdf annotation (koreader#10287) @hius07
* Folder Menu: sign for Home folder (koreader#10288) @hius07
* ListMenu: show mark for books with highlights (koreader#10276) @hius07
* Calendar view's day view: thicker separator at 00:00 (koreader#10289) @poire-z
* PageBrowser: tweak scrolling behaviour at book start/end (koreader#10289) @poire-z
* Make `kodev check` feature complete (koreader#8682) @yparitcher
* macOS: support for M1 building (koreader#10291) @ptrm
* Reader: do not apply font size and spacing out of range (koreader#10295, koreader#10307) @hius07
* File browser: show Folder Menu on long-press on Home icon (koreader#10298) @hius07
* SSH.koplugin: fix cant stop SSH server bug when pid file's stale (koreader#10300) @weijiuqiao
* PM: Optimize task queue handling around standby (koreader#10203) @zwim
* statistic.koplugin: fix today's timeline showing next day when within custom offset (koreader#10299) @weijiuqiao
* ReaderThumbnails: update cached page thumbnail on bookmark note change (koreader#10303) @hius07
* SDL: add multitouch support (koreader#10334) @Frenzie
* SDL: add HiDPI support (koreader#10341) @Frenzie
* BookInfo: fix crash on show cover (koreader#10315) @hius07
* Deal with table.pack corner-cases properly (koreader#10350) @NiLuJe
* Android: add Tagus Gea support (<koreader/android-luajit-launcher#412>) @Alfedi

[Full changelog](koreader/koreader@v2023.03...v2023.04) — [closed milestone issues](https://github.com/koreader/koreader/milestone/63?closed=1)

---

Installation instructions: [Android](https://github.com/koreader/koreader/wiki/Installation-on-Android-devices) • [Cervantes](https://github.com/koreader/koreader/wiki/Installation-on-BQ-devices) • [ChromeOS](https://github.com/koreader/koreader/wiki/Installation-on-Chromebook-devices) • [Kindle](https://github.com/koreader/koreader/wiki/Installation-on-Kindle-devices) • [Kobo](https://github.com/koreader/koreader/wiki/Installation-on-Kobo-devices) • [PocketBook](https://github.com/koreader/koreader/wiki/Installation-on-PocketBook-devices) • [ReMarkable](https://github.com/koreader/koreader/wiki/Installation-on-ReMarkable) • [Desktop Linux](https://github.com/koreader/koreader/wiki/Installation-on-desktop-linux) • [MacOS](https://github.com/koreader/koreader/wiki/Installation-on-MacOS)
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
@hius07
File browser: show Folder Menu on long-press on Home icon (koreader#1…
a393933 
…0298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes
@poire-z poire-z poire-z approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.04

Development

Successfully merging this pull request may close these issues.

5 participants

@hius07 @mergen3107 @NiLuJe @poire-z @Frenzie