I tried this feature and can crash it.

1. FM, currently in Home folder.
2. Click home, new window pops up, so higher than home. Home is /storage/emulated/0/Books. I went to /storage/emulated.
3. However, KOReader does not see the 0 directory there (I think that was the case all the time).
4. However, if I click home icon now, it freezes then crashes. I’ll try to attach the bomb crash in a second.

Previously hitting home was bringing me home directly. Is there a way to bring this back?

I wasn’t able to save it :(
When I clicked Save report, it crashed completely to launcher.

An Android issue. /storage/emulated must be handled in a special way.

@mergen3107 , do you see your Home folder in the list? Can you press it and go Home?

I can only see the folder with “(Home)” when I am inside Home somewhere.

Anywhere outside Home it crashes before window pops up

The bug (#10198 (comment)) is not related to this PR.
But in any case the upper parts of /storage/emulated/0 should not be shown in the Folder Menu on Android.

Regaring the Home button: we can go Home via
-the Plus menu
-assigning an action to long-pressing the Home titlebar icon
-or maybe it is good to add a separate (topmost) Home button to the Folder Menu

I guess long-press would be fine ? I was also a bit surprised that i now have to tap twice to go to home, but that's may be just because of the icon ? dunno if the hamburger icon is better as it's not really a menu with options like in Book map and Page browser.
Also, may be your text "(Home)" could be replace by a "home" unicode symbol to make it easier to catch the eye and tap ?

Long-pressing on top left corner is free and can be assigned via Gesture manager.

The only home character:

Long-pressing on top left corner is free and can be assigned via Gesture manager.

Right, so let that be. Do we have a default for it in File browser? Should "go home" be it if not?

The only home character:

May be without parens (and a bit more spaces if needed) ?

There might be some others to try in our nerdfont.
https://www.nerdfonts.com/cheat-sheet and search for "home".

(Always a bit tedious to find the right codepoint as we shift some a bit; #9526 (comment))

Yes, I've tried that nerdfonts sheet, other symbols are not supported in Noto-Sans.

No default gesture:

Before we fight to death for the icon design, let me suggest one conservative thing:

1. Let’s keep the single tap on the Home icon as it is: bring people to home.
2. For the new folder list*, let’s put it either as long-tap on the icon (or corner, I don’t really use the corners) or as second icon like hamburger menu.

• Honestly, new folder list would make a lot of sense if it was activated when the full path below “KOReader” title. This would resemble File Explorer in Windows, Dolphin on Linux, WinSCP, etc

Yes, I've tried that nerdfonts sheet, other symbols are not supported

Right, can't find any other ones.
So, let's go with this one: it looks similar with the chimney on the same side :) it's solid black, but ok, it catches the eye better that way.

Before we fight to death for the icon design

Well, we're disappoitned gladiators, not enough choices to fight about :/

About the change, I've never used this button enough to be bothered. But it looks nice and somehow give more choices/ways to go up (people requested that), without getting too much against habits (yes, you tap it and you don't go immediately, but it's just a tap away, and you can decide to stop in between, or go up 3 levels instead of taping 3 times).

Honestly, new folder list would make a lot of sense if it was activated when the full path below “KOReader” title.

Except in the Dict lookup result, I don't think we have much of that kind of UX (anonymous text acting like buttons)?

but it's just a tap away

For me it is deal breaking because it crashes on upper folder :D
And I go outside a lot to find other non-book files

because it crashes on upper folder

Thank you for the report, fixed already.

Sorry, didn’t see :) thanks! Will test tomorrow

@hius07
Thanks for quick response!

No more crash in -27.

Only weird thing is that in / folder, it says “Content is limited, etc”, and there is only one folder, but it weirdly says “/torage”. It works well and brings to “/storage”, but it weird that it is spelt that way.

Also, in /storage there is no 0 folder, so the only way to go back is to use the plus button.

I really now think that the old Home button icon should have at least an extra row that brings you home.

I used go home button a lot, even more than I realized it, especially now when I have to use the Plus button, then seek for the Go to home row (which is after Set as home button). Very inconvenient.

I tried setting goHome action to the long-press on top left corner and found it convenient.

I can’t conveniently use corner taps and long taps on Onyx: screen frame is rounded at corners and these touch areas are unreliable to use. So I disabled all corner actions.

Is there an option of long press for the button itself? E. g.,

• Tap: goHome
• Long tap: choose folder ?

+1 for the home button being home on tap and any menu on hold, when i am in the FM the only place i need to go quickly is home and i use the button alot

Yeah, it would also track with the "this looks like a context menu", and context-menus being a right-click kinda thing (which is often bound to long-tap on trackpads).

We can go two ways:
-add "Show folder menu" to Dispatcher and free tap/long-press on top left corner in Gesture manager
-hardcode tap/long-press to Go home / Show folder menu and add a setting "Show folder menu on Home icon tap" to Home folder settings submenu.

I can't quite think of a use-case for having this bound elsewhere, but that's just me ;).

I know it's practical (for power users - and us developpers?, although it always look odd to me to get the callback far away from the button definition) to handle corner buttons via corner gestures, moreover when a user will always get a "home" button that may not have anything to do with the action he has assigned to that corner :)
So, I won't mind removing this top left corner from gestures/dispatcher (but then, you'll probably get some old users like those above complaining you killed their habbits :) and add proper callback in the button definition:

hardcode tap/long-press to Go home / Show folder menu and add a setting "Show folder menu on Home icon tap" to Home folder settings submenu.

It may look a bit odd having both the folders tree list + a setting, but may be if it's at bottom with a separator, with the current directory above (that the user will probably not tap), it could be ok.
If I understand what you meant, I guess the setting could say [ ] Show this on tap - but I don't think I did anything for a refreshed text_func for the buttons in the ButtonTable (I just did enabled_func), so it might need a bit more coding.

Or just go with the flow of old users and have tap on the home button (it's a home, not a hamburger inviting to get a menu) go home - and hardcoded long-press show the tree list menu.
Dunno really :/

I think being able to override it is probably more elegant in theory, but I have no strong preference.

I meant to hardcode tap/long-press to GoHome/ShowFolderMenu and have a setting to switch actions, tap/long-press -> ShowFolderMenu/GoHome.

I meant to hardcode tap/long-press to GoHome/ShowFolderMenu and have a setting to switch actions, tap/long-press -> ShowFolderMenu/GoHome.

That's what I meant with [ ] Show this on tap (show this menu on tap, and implicitely "go home with long-press) - if you want this in the folder tree list.
But I guess having it in the regular top menu settings (in Home folder settings> ?) is probably less confusing and leave this folder list cleaner.

Casting another vote for a way to override this new behavior. Like many other people, I keep a flat directory structure and mainly use the home button to refresh after file transfers. Originally discussed in #7477

Thinking again, it might not that often be used/useful to deserve a setting, even if it's fancy and not many people will see it if set on long-press.
Tap on a home button => go home
Long-press on a home button gives the home context menu/neighbour directories.