Sync book statistics: add to dispatcher#10285
Merged
Merged
Conversation
94cc549 to
0e38a48
Compare
poire-z
reviewed
Apr 1, 2023
Comment on lines
+2985
to
+2987
| text = _("Syncing book statistics, this might take a while…"), | ||
| timeout = 1, | ||
| }) |
Contributor
There was a problem hiding this comment.
I guess the sync process is blocking, and this stays on until it's done, the timeout is there so it just disappear when the sync process is done?
Contributor
Author
There was a problem hiding this comment.
That's right, the same reason for using nextTick below
| end | ||
|
|
||
| function ReaderStatistics.onSync(local_path, cached_path, income_path) | ||
| function ReaderStatistics:isSyncPossible() |
Contributor
There was a problem hiding this comment.
rgrep Possible gives nothing, so we're not used to that. May be ReaderStatistics:canSync() ?
Contributor
|
And congratulation for your first PR ! |
poire-z
reviewed
Apr 1, 2023
| timeout = 1, | ||
| }) | ||
|
|
||
| UIManager:nextTick(function () |
Contributor
There was a problem hiding this comment.
no space needed/wanted between function and ()
poire-z
reviewed
Apr 1, 2023
Comment on lines
+2990
to
+2994
| SyncService.sync(self.settings.sync_server, db_location, self.onSyncServiceSync) | ||
| end) | ||
| end | ||
|
|
||
| function ReaderStatistics.onSyncServiceSync(local_path, cached_path, income_path) |
Contributor
There was a problem hiding this comment.
I would let this one with its original name ReaderStatistics.onSync(...) just because we don't know if there's not anywhere else something throwing a "Sync" event and expecting handlers to be named onSync (I think we don't, fortunately :)
I see VocabularyBuilder.onSync() has one with the same name.
I don't think we have any such "sync everything" use (and I don't know if we would ever need/want it - one could make a gesture/profile to trigger the ones he needs).
But may be they deserve a more complex name than just "Sync" ? Or just not have a "on" prefix, so we don't risk triggering them with a broadcastEvent(Event:new("Sync")).
Pinging @weijiuqiao who implemented both these onSync for thoughts.
Anyway, keeping the original name would have avoided us to wonder about all that :) It's not too late :)
Contributor
Author
There was a problem hiding this comment.
Right, I will revert that :)
Contributor
Author
There was a problem hiding this comment.
Wanted to maintain distinction between dispatcher ecent and sync method
poire-z
approved these changes
Apr 1, 2023
Frenzie
reviewed
Apr 1, 2023
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
TranHHoang
added a commit
to TranHHoang/koreader
that referenced
this pull request
May 26, 2023
KOReader 2023.04 "Solar Panel"  It's been another busy month squashing many bugs. Our Mac users will be happy to hear that I told macOS we've supported HiDPI since long before anyone came up with such terminology (koreader#10341), and that the program can now natively build on M1 devices (koreader#10291). Solar panel credit: <https://openclipart.org/detail/294030/solar-energy> by gnokii We'd like to thank all contributors for their efforts. Some highlights since the previous release include: * Readerzooming: fix use of default settings (koreader#10205) @hius07 * ButtonDialog/ButtonDialogTitle: consistent 'width' handling (koreader#10230) @poire-z * MovableContainer: add support for anchoring initial position (koreader#10230) @poire-z * Book map, Page browser: add top left menu (koreader#10230) @poire-z * Book style tweak: add button with CSS suggestions (koreader#10230) @poire-z * crengine: fix parsing of multibytes encodings (koreader#10230) @poire-z * readerstyletweak: update profiles on unregistering in dispatcher (koreader#10247) @hius07 * Filesearcher: add search in book metadata (koreader#10198) @hius07 * Fix: Updated legacy directory, which crashed the program (koreader#10260) @Mochitto * ReaderLink: allow a forward location stack (koreader#10228) @yparitcher * BookInfo: add page information (koreader#10255) @hius07 * Center pdf manual zoom mode (koreader#10246) @nairyosangha * File browser: add Folder Menu (koreader#10275) @hius07 * Calendar view: add options to change start time of days (koreader#10254) @weijiuqiao * filechooser: fix crash on "unreadable content" (koreader#10283) @hius07 * Sync book statistics: add to dispatcher (koreader#10285) @ptrm * [plugin] Exporter: use util.getSafeFilename() to remove illegal characters from output filename (koreader#10282) @Mochitto * readerbookmark: fix writing pdf annotation (koreader#10287) @hius07 * Folder Menu: sign for Home folder (koreader#10288) @hius07 * ListMenu: show mark for books with highlights (koreader#10276) @hius07 * Calendar view's day view: thicker separator at 00:00 (koreader#10289) @poire-z * PageBrowser: tweak scrolling behaviour at book start/end (koreader#10289) @poire-z * Make `kodev check` feature complete (koreader#8682) @yparitcher * macOS: support for M1 building (koreader#10291) @ptrm * Reader: do not apply font size and spacing out of range (koreader#10295, koreader#10307) @hius07 * File browser: show Folder Menu on long-press on Home icon (koreader#10298) @hius07 * SSH.koplugin: fix cant stop SSH server bug when pid file's stale (koreader#10300) @weijiuqiao * PM: Optimize task queue handling around standby (koreader#10203) @zwim * statistic.koplugin: fix today's timeline showing next day when within custom offset (koreader#10299) @weijiuqiao * ReaderThumbnails: update cached page thumbnail on bookmark note change (koreader#10303) @hius07 * SDL: add multitouch support (koreader#10334) @Frenzie * SDL: add HiDPI support (koreader#10341) @Frenzie * BookInfo: fix crash on show cover (koreader#10315) @hius07 * Deal with table.pack corner-cases properly (koreader#10350) @NiLuJe * Android: add Tagus Gea support (<koreader/android-luajit-launcher#412>) @Alfedi [Full changelog](koreader/koreader@v2023.03...v2023.04) — [closed milestone issues](https://github.com/koreader/koreader/milestone/63?closed=1) --- Installation instructions: [Android](https://github.com/koreader/koreader/wiki/Installation-on-Android-devices) • [Cervantes](https://github.com/koreader/koreader/wiki/Installation-on-BQ-devices) • [ChromeOS](https://github.com/koreader/koreader/wiki/Installation-on-Chromebook-devices) • [Kindle](https://github.com/koreader/koreader/wiki/Installation-on-Kindle-devices) • [Kobo](https://github.com/koreader/koreader/wiki/Installation-on-Kobo-devices) • [PocketBook](https://github.com/koreader/koreader/wiki/Installation-on-PocketBook-devices) • [ReMarkable](https://github.com/koreader/koreader/wiki/Installation-on-ReMarkable) • [Desktop Linux](https://github.com/koreader/koreader/wiki/Installation-on-desktop-linux) • [MacOS](https://github.com/koreader/koreader/wiki/Installation-on-MacOS)
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the sync book statistics action to dispatcher, along with InfoMessage shown during sync.
This change is