Skip to content

Conversation

@matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek requested a review from gauron99 April 14, 2025 07:55
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@knative-prow knative-prow bot requested review from jrangelramos and rhuss April 14, 2025 07:55
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2025
@matejvasek matejvasek requested review from lkingland and matzew and removed request for jrangelramos and rhuss April 14, 2025 07:55
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.43%. Comparing base (d028013) to head (4a687fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2784      +/-   ##
==========================================
+ Coverage   61.58%   62.43%   +0.84%     
==========================================
  Files         131      131              
  Lines       15793    15793              
==========================================
+ Hits         9726     9860     +134     
+ Misses       5152     4990     -162     
- Partials      915      943      +28     
Flag Coverage Δ
e2e-test 35.34% <ø> (ø)
e2e-test-oncluster 33.69% <ø> (+1.40%) ⬆️
e2e-test-oncluster-runtime 28.10% <ø> (?)
e2e-test-runtime-go 25.71% <ø> (?)
e2e-test-runtime-node 25.07% <ø> (?)
e2e-test-runtime-quarkus 25.15% <ø> (?)
e2e-test-runtime-rust 24.64% <ø> (?)
e2e-test-runtime-springboot 24.70% <ø> (?)
e2e-test-runtime-typescript 25.15% <ø> (?)
integration-tests 48.61% <ø> (+1.81%) ⬆️
unit-tests 48.66% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @lkingland @matzew

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@knative-prow
Copy link

knative-prow bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0896b90 into knative:main Apr 14, 2025
34 checks passed
matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Oct 5, 2025
picking knative#2784

Signed-off-by: Matej Vašek <mvasek@redhat.com>
matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Oct 6, 2025
* feat: remote storage class

picking knative#2693

Co-authored-by: Luke Kingland <lkinglan@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Python Middleware v2 Scaffolding

picking knative#2685

Co-authored-by: Luke Kingland <lkinglan@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Fix Python S2I On-Cluster build

picking knative#2770

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Fix http port 433 => 443

picking knative#2742

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Trust loopback builders

picking knative#2750

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Add testcase for Go private repositories

picking knative#2748

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Test adjustments

picking knative#2751

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Allow host mounts for build phahse

picking knative#2753

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Use s2i in standard mode, not "as-dockerfile"

picking knative#2764

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Improvements for Go s2i assembler

picking knative#2765

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* S2I (source-to-image) host binds

picking knative#2766

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Make build binds more similar to runtime binds

picking knative#2768

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Add guideline for private Go module usage

picking knative#2771

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Improve Go templates README

picking knative#2848

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Fix detection of hostname resolution failure

picking knative#2841

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Fix: Go scaffolding uses correct module name

picking knative#2769

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Fix non-containerized build/run /w external deps

picking knative#2847

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Tekton 1.0.x fixes

picking #1349

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Fix co-scheduling

picking #1358

Co-authored-by: Jefferson Ramos <jeramos@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>

* test: fix gitlab test

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* dapr install upgrade

picking knative#3055

Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: Luke Kingland <lkinglan@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fixup: go.mod

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fixup: update alpine version

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Migrate golangci-lint config to v2

picking knative#2781

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Bump golangci-lint version

picking knative#2784

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix flaky unit test

picking knative#2749

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: Luke Kingland <lkinglan@redhat.com>
Co-authored-by: Jefferson Ramos <jeramos@redhat.com>
Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants