Skip to content

Don't mark entry edit as modified when attribute selection changes#3041

Merged
phoerious merged 1 commit intorelease/2.4.2from
hotfix/entryedit-modified
Apr 20, 2019
Merged

Don't mark entry edit as modified when attribute selection changes#3041
phoerious merged 1 commit intorelease/2.4.2from
hotfix/entryedit-modified

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

Type of change

  • ✅ Bug fix (non-breaking change which fixes an issue)

Description and Context

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • ✅ My change requires a change to the documentation, and I have updated it accordingly.
  • ✅ I have added tests to cover my changes.

* When selecting another attribute in the advanced tab, do not mark the entry as modified (nothing was changed)
* Also do not mark as modified when the notes checkbox is checked/unchecked (doesn't change entry)
* Fixes #3013
@droidmonkey droidmonkey added this to the v2.4.2 milestone Apr 19, 2019
@droidmonkey droidmonkey requested a review from phoerious April 19, 2019 20:52
@phoerious phoerious merged commit cb442f8 into release/2.4.2 Apr 20, 2019
@phoerious phoerious deleted the hotfix/entryedit-modified branch April 20, 2019 15:51
droidmonkey added a commit that referenced this pull request May 31, 2019
- Improve resilience against memory attacks - overwrite memory before free [#3020]
- Prevent infinite save loop when location is unavailable [#3026]
- Attempt to fix quitting application when shutdown or logout issued [#3199]
- Support merging database custom data [#3002]
- Fix opening URL's with non-http schemes [#3153]
- Fix data loss due to not reading all database attachments if duplicates exist [#3180]
- Fix entry context menu disabling when using keyboard navigation [#3199]
- Fix behaviors when canceling an entry edit [#3199]
- Fix processing of tray icon click and doubleclick [#3112]
- Update group in preview widget when focused [#3199]
- Prefer DuckDuckGo service over direct icon download (increases resolution) [#2996]
- Remove apply button in application settings [#3019]
- Use winqtdeploy on Windows to correct deployment issues [#3025]
- Don't mark entry edit as modified when attribute selection changes [#3041]
- Use console code page CP_UTF8 on Windows if supported [#3050]
- Snap: Fix locking database with session lock [#3046]
- Snap: Fix theming across Linux distributions [#3057]
- Snap: Use SNAP_USER_COMMON and SNAP_USER_DATA directories [#3131]
- KeeShare: Automatically enable WITH_XC_KEESHARE_SECURE if quazip is found [#3088]
- macOS: Fix toolbar text when in dark mode [#2998]
- macOS: Lock database on switching user [#3097]
- macOS: Fix global Auto-Type when the database is locked [#3138]
- Browser: Close popups when database is locked [#3093]
- Browser: Add tests [#3016]
- Browser: Don't create default group if custom group is enabled [#3127]
@phoerious phoerious added pr: bugfix Pull request fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix Pull request fixes a bug ux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants