Fix toolbar text color on macOS when in dark mode#2998
Merged
droidmonkey merged 1 commit intokeepassxreboot:release/2.4.2from Apr 16, 2019
mko-x:fix-toolbar-action-color-osx
Merged
Fix toolbar text color on macOS when in dark mode#2998droidmonkey merged 1 commit intokeepassxreboot:release/2.4.2from mko-x:fix-toolbar-action-color-osx
droidmonkey merged 1 commit intokeepassxreboot:release/2.4.2from
mko-x:fix-toolbar-action-color-osx
Conversation
phoerious
previously requested changes
Apr 13, 2019
droidmonkey
requested changes
Apr 15, 2019
* Correct color setting only if dark mode is enabled
droidmonkey
approved these changes
Apr 15, 2019
Member
|
I'm a bit worried about Qt fixing this issue, but our hack staying in the code forever. |
Author
|
Maybe adding a compiler warning if the QT major version raises is an idea. |
droidmonkey
added a commit
that referenced
this pull request
May 31, 2019
- Improve resilience against memory attacks - overwrite memory before free [#3020] - Prevent infinite save loop when location is unavailable [#3026] - Attempt to fix quitting application when shutdown or logout issued [#3199] - Support merging database custom data [#3002] - Fix opening URL's with non-http schemes [#3153] - Fix data loss due to not reading all database attachments if duplicates exist [#3180] - Fix entry context menu disabling when using keyboard navigation [#3199] - Fix behaviors when canceling an entry edit [#3199] - Fix processing of tray icon click and doubleclick [#3112] - Update group in preview widget when focused [#3199] - Prefer DuckDuckGo service over direct icon download (increases resolution) [#2996] - Remove apply button in application settings [#3019] - Use winqtdeploy on Windows to correct deployment issues [#3025] - Don't mark entry edit as modified when attribute selection changes [#3041] - Use console code page CP_UTF8 on Windows if supported [#3050] - Snap: Fix locking database with session lock [#3046] - Snap: Fix theming across Linux distributions [#3057] - Snap: Use SNAP_USER_COMMON and SNAP_USER_DATA directories [#3131] - KeeShare: Automatically enable WITH_XC_KEESHARE_SECURE if quazip is found [#3088] - macOS: Fix toolbar text when in dark mode [#2998] - macOS: Lock database on switching user [#3097] - macOS: Fix global Auto-Type when the database is locked [#3138] - Browser: Close popups when database is locked [#3093] - Browser: Add tests [#3016] - Browser: Don't create default group if custom group is enabled [#3127]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix toolbar action color macOS
Type of change
Description and Context
The text for the action icons in toolbar was not readable in macOS, changed to white text color.
Screenshots
Before
After
Testing strategy
Local Release Build with Tests